Re: [PATCH v5 4/9] video: Add generic HDMI infoframe helpers

["Ville Syrjälä" <ville.syrjala@linux.intel.com>]

On Fri, Feb 22, 2013 at 08:03:26AM +0100, Thierry Reding wrote:
<snip>
> +enum hdmi_audio_coding_type {
> +	HDMI_AUDIO_CODING_TYPE_STREAM,
> +	HDMI_AUDIO_CODING_TYPE_PCM,
> +	HDMI_AUDIO_CODING_TYPE_AC3,
> +	HDMI_AUDIO_CODING_TYPE_MPEG1,
> +	HDMI_AUDIO_CODING_TYPE_MP3,
> +	HDMI_AUDIO_CODING_TYPE_MPEG2,
> +	HDMI_AUDIO_CODING_TYPE_AAC_LC,
> +	HDMI_AUDIO_CODING_TYPE_DTS,
> +	HDMI_AUDIO_CODING_TYPE_ATRAC,
> +	HDMI_AUDIO_CODING_TYPE_DSD,
> +	HDMI_AUDIO_CODING_TYPE_EAC3,
> +	HDMI_AUDIO_CODING_TYPE_DTS_HD,
> +	HDMI_AUDIO_CODING_TYPE_MLP,
> +	HDMI_AUDIO_CODING_TYPE_DST,
> +	HDMI_AUDIO_CODING_TYPE_WMA_PRO,

+ HDMI_AUDIO_CODING_TYPE_EXT or something like it?

> +};
> +
> +enum hdmi_audio_sample_size {
> +	HDMI_AUDIO_SAMPLE_SIZE_STREAM,
> +	HDMI_AUDIO_SAMPLE_SIZE_16,
> +	HDMI_AUDIO_SAMPLE_SIZE_20,
> +	HDMI_AUDIO_SAMPLE_SIZE_24,
> +};
> +
> +enum hdmi_audio_sample_frequency {
> +	HDMI_AUDIO_SAMPLE_FREQUENCY_STREAM,
> +	HDMI_AUDIO_SAMPLE_FREQUENCY_32000,
> +	HDMI_AUDIO_SAMPLE_FREQUENCY_44100,
> +	HDMI_AUDIO_SAMPLE_FREQUENCY_48000,
> +	HDMI_AUDIO_SAMPLE_FREQUENCY_88200,
> +	HDMI_AUDIO_SAMPLE_FREQUENCY_96000,
> +	HDMI_AUDIO_SAMPLE_FREQUENCY_176400,
> +	HDMI_AUDIO_SAMPLE_FREQUENCY_192000,
> +};
> +
> +enum hdmi_audio_coding_type_ext {
> +	HDMI_AUDIO_CODING_TYPE_EXT_STREAM,

The spec is a bit confusing w.r.t. this value, but I think this is
correct. Any other value is illegal when CT!=15, and when CT==15,
CXT=0 means that look at CT (infinite loop anyone?), or stream header.
Since the infinite loop option doesn't make sense, looking at the
stream header is the only option. Although I think it would be
generally safer to avoid that specific combination. I'm sure some
"clever" guy would actually implement the infinite loop instead.

> +	HDMI_AUDIO_CODING_TYPE_EXT_HE_AAC,
> +	HDMI_AUDIO_CODING_TYPE_EXT_HE_AAC_V2,
> +	HDMI_AUDIO_CODING_TYPE_EXT_MPEG_SURROUND,
> +};
> +

-- 
Ville Syrjälä
Intel OTC