From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [PATCH 10/30] staging: sync: Export sync API symbols Date: Fri, 1 Mar 2013 05:55:29 -0800 Message-ID: <20130301135529.GB27373@kroah.com> References: <1362098606-26469-1-git-send-email-john.stultz@linaro.org> <1362098606-26469-11-git-send-email-john.stultz@linaro.org> <20130301020008.GB13367@kroah.com> <51302792.6040408@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Erik Gilling Cc: John Stultz , lkml , Maarten Lankhorst , Daniel Vetter , Rob Clark , Sumit Semwal , dri-devel@lists.freedesktop.org, Android Kernel Team List-Id: dri-devel@lists.freedesktop.org On Fri, Mar 01, 2013 at 12:21:24AM -0800, Erik Gilling wrote: > On Thu, Feb 28, 2013 at 7:59 PM, John Stultz wrote: > >> Also, EXPORT_SYMBOL_GPL() perhaps? > >> > >> And who is using these exports? > > > > > > From some quick git grepping... > > As John pointed out, the exynos and msm display and code uses them. I > know nvidia is working on adding suport to their tegra tree. My knee > jerk reaction is to make the export as permissible as possible. That > being said, all of the ARM SoC vendors I've worked with have GPL > kernel drivers even if their user space is closed. I'll reach out to > them and ask for their opinions. Are there any issues with keeping > them EXPORT_SYMBOL? There's no "issues", it's just that it is preferred by some people and companies to add new symbols to the kernel in this manner. It's really up to you / Google as you are the ones contributing the code. thanks, greg k-h