From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v3 0/2] Enhance EDID quirks to allow forcing a mode Date: Sat, 23 Mar 2013 13:56:31 +0100 Message-ID: <20130323125631.GG9021@phenom.ffwll.local> References: <1363993687-6935-1-git-send-email-dylan.semler@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ee0-f47.google.com (mail-ee0-f47.google.com [74.125.83.47]) by gabe.freedesktop.org (Postfix) with ESMTP id 45227E6140 for ; Sat, 23 Mar 2013 05:53:44 -0700 (PDT) Received: by mail-ee0-f47.google.com with SMTP id e52so2588090eek.20 for ; Sat, 23 Mar 2013 05:53:43 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1363993687-6935-1-git-send-email-dylan.semler@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Dylan Semler Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On Fri, Mar 22, 2013 at 07:08:05PM -0400, Dylan Semler wrote: > Changes in this version > * Uses drm_cvt_mode() instead of drm_gtf_mode() to build modeline > * Adds bool to specify reduced blanking to edid_quirk_force_mode > * Removes preferred bit from all other modes > > There is at least one monitor that doesn't report its native resolution > in its EDID block. This enhancement extends the EDID quirk logic to > make monitors like this "just work". > > The first patch in this series sets up a new quirk list where monitors' > correct width, height, refresh rate, and reduced blanking parameters are > specified. When a matching monitor is attached the full mode is > calculated with drm_cvt_mode() and added to the connector. The > DRM_MODE_TYPE_PREFERRED bit is set on the new mode and unset from all > other modes. > > The first patch also defines a new quirk bit: EDID_QUIRK_FORCE_MODE. > This bit needs to be set for the new quirk list discribed above to be > checked. > > The second patch adds the offending monitor to the quirk lists. > > Dylan Semler (2): > drm: Enhance EDID quirks to explicitly set a mode > drm: Add EDID force quirk for MMT Monitor2Go HD+ Ah, missed this resend of your patches. Looks good to me, but I guess Dave want's to have Ajax's ack, too. Anyway for the series: Acked-by: Daniel Vetter Cheers, Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch