dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Daniel Kurtz <djkurtz@chromium.org>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm: Fix error message in drmWaitVBlank
Date: Thu, 28 Mar 2013 08:34:45 -0700	[thread overview]
Message-ID: <20130328083445.79b801fd@jbarnes-desktop> (raw)
In-Reply-To: <1364450740-10118-1-git-send-email-djkurtz@chromium.org>

On Thu, 28 Mar 2013 14:05:40 +0800
Daniel Kurtz <djkurtz@chromium.org> wrote:

> If clock_gettime did fail, it would return -1 and set errno.
> What we really want to strerror() is the errno.
> 
> Signed-off-by: Daniel Kurtz <djkurtz@chromium.org>
> ---
>  xf86drm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/xf86drm.c b/xf86drm.c
> index 2a74c80..4791a05 100644
> --- a/xf86drm.c
> +++ b/xf86drm.c
> @@ -1946,7 +1946,7 @@ int drmWaitVBlank(int fd, drmVBlankPtr vbl)
>  
>      ret = clock_gettime(CLOCK_MONOTONIC, &timeout);
>      if (ret < 0) {
> -	fprintf(stderr, "clock_gettime failed: %s\n", strerror(ret));
> +	fprintf(stderr, "clock_gettime failed: %s\n", strerror(errno));
>  	goto out;
>      }
>      timeout.tv_sec++;

Applied, thanks.

-- 
Jesse Barnes, Intel Open Source Technology Center

      reply	other threads:[~2013-03-28 15:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-28  6:05 [PATCH] drm: Fix error message in drmWaitVBlank Daniel Kurtz
2013-03-28 15:34 ` Jesse Barnes [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130328083445.79b801fd@jbarnes-desktop \
    --to=jbarnes@virtuousgeek.org \
    --cc=djkurtz@chromium.org \
    --cc=dri-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox