From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH] drm: don't unlock in the addfb error paths
Date: Thu, 11 Apr 2013 16:09:06 +0200
Message-ID: <20130411140906.GM27612@phenom.ffwll.local>
References: <1364417135-30928-1-git-send-email-daniel.vetter@ffwll.ch>
	<20130328102255.GG4469@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org>
Received: from mail-ea0-f182.google.com (mail-ea0-f182.google.com
	[209.85.215.182])
	by gabe.freedesktop.org (Postfix) with ESMTP id 318B5E661C
	for <dri-devel@lists.freedesktop.org>;
	Thu, 11 Apr 2013 07:06:08 -0700 (PDT)
Received: by mail-ea0-f182.google.com with SMTP id q15so786536ead.13
	for <dri-devel@lists.freedesktop.org>;
	Thu, 11 Apr 2013 07:06:06 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20130328102255.GG4469@intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>, Dave Airlie <airlied@gmail.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, Ray Strode <rstrode@redhat.com>, DRI Development <dri-devel@lists.freedesktop.org>
List-Id: dri-devel@lists.freedesktop.org

On Thu, Mar 28, 2013 at 12:22:55PM +0200, Ville Syrj=E4l=E4 wrote:
> On Wed, Mar 27, 2013 at 09:45:35PM +0100, Daniel Vetter wrote:
> > We don't grab the modeset locks any more since
> > =

> > commit 468174f748603497e73dba9b5c6d1d9f71121486
> > Author: Daniel Vetter <daniel.vetter@ffwll.ch>
> > Date:   Tue Dec 11 00:09:12 2012 +0100
> > =

> >     drm: push modeset_lock_all into ->fb_create driver callbacks
> > =

> > Reported-by: Ray Strode <rstrode@redhat.com>
> > Cc: Ray Strode <rstrode@redhat.com>
> > Cc: Dave Airlie <airlied@gmail.com>
> > Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> =

> Reviewed-by: Ville Syrj=E4l=E4 <ville.syrjala@linux.intel.com>

Dave?

> =

> > ---
> >  drivers/gpu/drm/drm_crtc.c |    2 --
> >  1 file changed, 2 deletions(-)
> > =

> > diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c
> > index 792c3e3..dd64a06 100644
> > --- a/drivers/gpu/drm/drm_crtc.c
> > +++ b/drivers/gpu/drm/drm_crtc.c
> > @@ -2326,7 +2326,6 @@ int drm_mode_addfb(struct drm_device *dev,
> >  	fb =3D dev->mode_config.funcs->fb_create(dev, file_priv, &r);
> >  	if (IS_ERR(fb)) {
> >  		DRM_DEBUG_KMS("could not create framebuffer\n");
> > -		drm_modeset_unlock_all(dev);
> >  		return PTR_ERR(fb);
> >  	}
> >  =

> > @@ -2506,7 +2505,6 @@ int drm_mode_addfb2(struct drm_device *dev,
> >  	fb =3D dev->mode_config.funcs->fb_create(dev, file_priv, r);
> >  	if (IS_ERR(fb)) {
> >  		DRM_DEBUG_KMS("could not create framebuffer\n");
> > -		drm_modeset_unlock_all(dev);
> >  		return PTR_ERR(fb);
> >  	}
> >  =

> > -- =

> > 1.7.10.4
> > =

> > _______________________________________________
> > dri-devel mailing list
> > dri-devel@lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/dri-devel
> =

> -- =

> Ville Syrj=E4l=E4
> Intel OTC

-- =

Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch