From: Daniel Vetter <daniel@ffwll.ch>
To: "\"David Müller (ELSOFT AG)\"" <d.mueller@elsoft.ch>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [DVO][PATCH] drm/i915: Fall back to bit banging mode for DVO transmitter detection
Date: Fri, 19 Apr 2013 16:31:37 +0200 [thread overview]
Message-ID: <20130419143137.GV6169@phenom.ffwll.local> (raw)
In-Reply-To: <51712248.8010504@elsoft.ch>
On Fri, Apr 19, 2013 at 12:54:00PM +0200, "David Müller (ELSOFT AG)" wrote:
> Daniel Vetter wrote:
> > On Fri, Apr 19, 2013 at 10:41:50AM +0200, "David Müller (ELSOFT AG)" wrote:
> >> + /* GMBUS NAK handling seems to be unstable, hence let the
> >> + * transmitter detection run in bit banging mode for now.
> >> + */
> >> + intel_gmbus_force_bit(i2c, true);
> >> +
> >> + dvoinit = dvo->dev_ops->init(&intel_dvo->dev, i2c);
> >> +
> >> + intel_gmbus_force_bit(i2c, false);
> >
> > Shouldn't we keep the dvo i2c line in bit-banging mode always, i.e.
> > restore gmbus mode only when dvo init failed?
> >
> > I suspect that for fickle hw not just init will fail ...
>
> As far as i can tell, the critical part is the NAK handling.
Ok, I've merged the patch for 3.10 with cc: stable.
Thanks, Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
prev parent reply other threads:[~2013-04-19 14:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-19 8:41 [DVO][PATCH] drm/i915: Fall back to bit banging mode for DVO transmitter detection "David Müller (ELSOFT AG)"
2013-04-19 9:14 ` Daniel Vetter
2013-04-19 10:54 ` "David Müller (ELSOFT AG)"
2013-04-19 14:31 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130419143137.GV6169@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=d.mueller@elsoft.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox