From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/prime: warn for non-empty handle lookup list during drm file release Date: Wed, 24 Apr 2013 19:07:14 +0200 Message-ID: <20130424170714.GY6169@phenom.ffwll.local> References: <1366819497-8358-1-git-send-email-imre.deak@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ea0-f175.google.com (mail-ea0-f175.google.com [209.85.215.175]) by gabe.freedesktop.org (Postfix) with ESMTP id 19761E5D51 for ; Wed, 24 Apr 2013 10:04:12 -0700 (PDT) Received: by mail-ea0-f175.google.com with SMTP id f15so845178eak.20 for ; Wed, 24 Apr 2013 10:04:12 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1366819497-8358-1-git-send-email-imre.deak@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Imre Deak , Dave Airlie Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On Wed, Apr 24, 2013 at 07:04:57PM +0300, Imre Deak wrote: > drm_gem_release should release all handles connected to the drm file and > so should also release the prime lookup entries of these handles. So > just WARN if this isn't the case. > > Signed-off-by: Imre Deak Reviewed-by: Daniel Vetter > --- > > drivers/gpu/drm/drm_prime.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/drm_prime.c b/drivers/gpu/drm/drm_prime.c > index 71c7315..dcde352 100644 > --- a/drivers/gpu/drm/drm_prime.c > +++ b/drivers/gpu/drm/drm_prime.c > @@ -488,11 +488,8 @@ EXPORT_SYMBOL(drm_prime_init_file_private); > > void drm_prime_destroy_file_private(struct drm_prime_file_private *prime_fpriv) > { > - struct drm_prime_member *member, *safe; > - list_for_each_entry_safe(member, safe, &prime_fpriv->head, entry) { > - list_del(&member->entry); > - kfree(member); > - } > + /* by now drm_gem_release should've made sure the list is empty */ > + WARN_ON(!list_empty(&prime_fpriv->head)); > } > EXPORT_SYMBOL(drm_prime_destroy_file_private); > > -- > 1.7.10.4 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch