From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 2/3] drm: Add probed modes in probe order Date: Tue, 11 Jun 2013 10:34:09 +0200 Message-ID: <20130611083409.GT22870@phenom.ffwll.local> References: <1370002628-16417-1-git-send-email-ville.syrjala@linux.intel.com> <1370002628-16417-2-git-send-email-ville.syrjala@linux.intel.com> <20130611074848.GC27632@cantiga.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mail-ea0-f176.google.com (mail-ea0-f176.google.com [209.85.215.176]) by gabe.freedesktop.org (Postfix) with ESMTP id 730AAE633D for ; Tue, 11 Jun 2013 01:34:14 -0700 (PDT) Received: by mail-ea0-f176.google.com with SMTP id z15so3086451ead.7 for ; Tue, 11 Jun 2013 01:34:13 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20130611074848.GC27632@cantiga.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Chris Wilson , Daniel Vetter , "Syrjala, Ville" , Dave Airlie , dri-devel List-Id: dri-devel@lists.freedesktop.org On Tue, Jun 11, 2013 at 08:48:48AM +0100, Chris Wilson wrote: > On Tue, Jun 11, 2013 at 09:15:29AM +0200, Daniel Vetter wrote: > > On Fri, May 31, 2013 at 2:17 PM, wrote: > > > From: Ville Syrj=E4l=E4 > > > > > > Keeping the modes in the same order as we probe them makes it a bit > > > easier to track what's happening. > > > > > > Signed-off-by: Ville Syrj=E4l=E4 > > = > > I've just added a regression fixer to my -fixes queue which depends > > upon the old behaviour ... I'll make a note to fix this once stuff is > > merged together again. For reference the patch this will break in > > -fixes is: > > = > > commit c3456fb3e4712d0448592af3c5d644c9472cd3c1 > > Author: Daniel Vetter > > Date: Mon Jun 10 09:47:58 2013 +0200 > > = > > drm/i915: prefer VBT modes for SVDO-LVDS over EDID > = > That is not the only place to have a subtle dependence upon the ordering > of modes in the list. I've now included latest drm-next into drm-intel-nightly. I guess we'll find out soon ;-) -Daniel -- = Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch