From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH v6 08/23] modetest: Add a command line parameter to set
	properties
Date: Thu, 27 Jun 2013 11:31:48 +0300
Message-ID: <20130627083148.GX5004@intel.com>
References: <1371245697-29504-1-git-send-email-laurent.pinchart@ideasonboard.com>
	<1371245697-29504-9-git-send-email-laurent.pinchart@ideasonboard.com>
	<20130624150837.GM5004@intel.com> <2998730.VBVDGyOTOW@avalon>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org>
Received: from mga14.intel.com (mga14.intel.com [143.182.124.37])
	by gabe.freedesktop.org (Postfix) with ESMTP id 0A4AEE655D
	for <dri-devel@lists.freedesktop.org>;
	Thu, 27 Jun 2013 01:31:52 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <2998730.VBVDGyOTOW@avalon>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org

On Thu, Jun 27, 2013 at 10:10:43AM +0200, Laurent Pinchart wrote:
> Hi Ville,
> =

> Thank you for the review.
> =

> On Monday 24 June 2013 18:08:37 Ville Syrj=E4l=E4 wrote:
> > On Fri, Jun 14, 2013 at 11:34:42PM +0200, Laurent Pinchart wrote:
> > > The -w parameter can be used to set a property value from the command
> > > line, using the target object ID and the property name.
> > > =

> > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > > ---
> > > =

> > >  tests/modetest/modetest.c | 108 ++++++++++++++++++++++++++++++++++++=
++++-
> > >  1 file changed, 106 insertions(+), 2 deletions(-)
> > > =

> > > diff --git a/tests/modetest/modetest.c b/tests/modetest/modetest.c
> > > index 778af62..858d480 100644
> > > --- a/tests/modetest/modetest.c
> > > +++ b/tests/modetest/modetest.c
> > =

> > <snip>
> > =

> > > @@ -1008,9 +1082,20 @@ static int parse_plane(struct plane_arg *p, co=
nst
> > > char *arg)> =

> > >  	return 0;
> > >  =

> > >  }
> > > =

> > > +static int parse_property(struct property_arg *p, const char *arg)
> > > +{
> > > +	if (sscanf(arg, "%d:%32[^:]:%" SCNu64, &p->obj_id, p->name, &p-
> >value)
> > > !=3D 3)
> > nit: could use stringification to get rid of the magic number 32 here.
> =

> What do you mean exactly ?

Something like this:

#define str(x) #x
#define xstr(x) str(x)
sscanf(arg, "%d:%" xstr(DRM_PROP_NAME_LEN) "[^:]:%" SCNu64, ...

Although it does make it a bit hard to parse for a human.

-- =

Ville Syrj=E4l=E4
Intel OTC