From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH] drm/rcar-du: Add missing dependency on CMA Date: Wed, 10 Jul 2013 12:07:24 +0100 Message-ID: <20130710110724.GD24508@sirena.org.uk> References: <1373453534-6425-1-git-send-email-broonie@kernel.org> <9815009.SJ9cp8Rvrj@avalon> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0651236256==" Return-path: Received: from cassiel.sirena.org.uk (cassiel.sirena.org.uk [80.68.93.111]) by gabe.freedesktop.org (Postfix) with ESMTP id 763A2E5C3C for ; Wed, 10 Jul 2013 04:07:44 -0700 (PDT) In-Reply-To: <9815009.SJ9cp8Rvrj@avalon> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Laurent Pinchart Cc: Laurent Pinchart , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0651236256== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="kvUQC+jR9YzypDnK" Content-Disposition: inline --kvUQC+jR9YzypDnK Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Jul 10, 2013 at 12:54:40PM +0200, Laurent Pinchart wrote: > On Wednesday 10 July 2013 11:52:14 Mark Brown wrote: > > config DRM_RCAR_DU > > tristate "DRM Support for R-Car Display Unit" > > - depends on DRM && ARM > > + depends on DRM && ARM && CMA > > select DRM_KMS_HELPER > > select DRM_KMS_CMA_HELPER > > select DRM_GEM_CMA_HELPER > Shouldn't we instead make DRM_GEM_CMA_HELPER depend on CMA ? Sadly select doesn't do the right thing with dependencies - it just ignores them. --kvUQC+jR9YzypDnK Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.20 (GNU/Linux) iQIcBAEBAgAGBQJR3UBkAAoJELSic+t+oim9RagP/RQEltm/ajneeWCVS++Iv9GG u2T51Ug28EMQB0w8DVvX1RbBlD8jlr9J5fQwWO3aIu8pK3WODgK1aRPUq8oCcav+ 2A3i6m/ZJJ2eiM9r2Gh/IpGZHEQQuvBHFfCojm7LJ+E+QZk2UtDhnKBSkWezu5+b btpqwQPYGalQkc6Fm9ImO/8auUwwYBmNpWa3UaremzTSpYQBXej3iq+pdBwOcClf unVZYjiOgcJSlUryUU4DR1R2rTiIvjZvGqnrDw+8R6orbqBuV8AkYnh0MGt9zwxo Sg9Rq4zxEkDd8H65/ddPV6fufTchDbhHNfwnFItywgx8OSyvZa1mfZTY1EjoSyY8 WDFlRF3BNi91d4uPE2QBGE/mS7vL1C2viiN1LOqgFXvlL397lSb177E8QDfQI08W zhFkwocs9mkjDki+6Ll+tgHD4++d/eSYqP8ihSD//kdOkUZF35tW0MDH4HeKXBf9 HuvTzZ+JgGzLba6/QE3mT6mGjN1jiOW2TOfZNfxr1u2IZM+wTa3M/J90DZjdn8Wi fPI1HqCXCDmuSFYNXM0dcaZygq4Dddz/RLpBnz6yYgZYP0m/gk2Nfcxx5CPA5AnM vtU/OXun5QgBIcmMv2OyJi9FeBKBORYTtaS2b4o7oD4Mrh51gtG6LI6ybM3jilxJ aMbHOmXojr8Yn1+jG01l =6CwW -----END PGP SIGNATURE----- --kvUQC+jR9YzypDnK-- --===============0651236256== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel --===============0651236256==--