From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sylvain 'ythier' Hitier Subject: [PATCH] uvesafb: Really allow mtrr being 0, as documented and warn()ed Date: Fri, 12 Jul 2013 18:25:54 +0200 Message-ID: <20130712162554.GA3789@begonia> References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wi0-f174.google.com (mail-wi0-f174.google.com [209.85.212.174]) by gabe.freedesktop.org (Postfix) with ESMTP id 5E5B3E6817 for ; Fri, 12 Jul 2013 09:26:06 -0700 (PDT) Received: by mail-wi0-f174.google.com with SMTP id k10so887831wiv.7 for ; Fri, 12 Jul 2013 09:26:05 -0700 (PDT) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Andy Lutomirski Cc: Dave Airlie , DRI mailing list , Torsten Kaiser List-Id: dri-devel@lists.freedesktop.org Hello, When: 2013-07-10_3@10-36-22 -0700 Who: Andy Lutomirski What: > On Wed, Jul 10, 2013 at 10:07 AM, Torsten Kaiser > wrote: > > Commit 63e28a7a5ffce59b645ca9cbcc01e1e8be56bd75, "uvesafb: Clean up > > MTRR code" contains the following change: > > > > @@ -1930,6 +1891,9 @@ static int uvesafb_setup(char *options) > > } > > } > > > > + if (mtrr != 3 && mtrr != 1) > > + pr_warn("uvesafb: mtrr should be set to 0 or 3; %d is > > unsupported", mtrr); > > + > > return 0; > > } > > #endif /* !MODULE */ > > > > Shouldn't this be && mtrr != 0? > > Indeed, and Sylvain Hitier (cc'd) sent a patch (off-list) that must > have gotten lost somewhere. RIP patch born on 2013-06-08_6@23-02-26 +0200 ... May your soul be happy, because here is a clone of you who will hopefully fulfill your quest: Fixup for commit "uvesafb: Clean up MTRR code" (63e28a7a5ffce59b645ca9cbcc01e1e8be56bd75) Signed-off-by: Sylvain "ythier" Hitier Acked-by: Andy Lutomirski Also-spotted-by: Torsten Kaiser --- drivers/video/uvesafb.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/video/uvesafb.c b/drivers/video/uvesafb.c index 296279b..2121fc3 100644 --- a/drivers/video/uvesafb.c +++ b/drivers/video/uvesafb.c @@ -1891,7 +1891,7 @@ static int uvesafb_setup(char *options) } } - if (mtrr != 3 && mtrr != 1) + if (mtrr != 3 && mtrr != 0) pr_warn("uvesafb: mtrr should be set to 0 or 3; %d is unsupported", mtrr); return 0; -- Regards, Sylvain "ythier" Hitier -- Business is about being busy, not being rich... Lived 777 days in a Debian package => http://en.wikipedia.org/wiki/Apt,_Vaucluse There's THE room for ideals in this mechanical place!