From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesse Barnes Subject: Re: [PATCH v2] drm/i915: fix long-standing SNB regression in power consumption after resume Date: Wed, 17 Jul 2013 07:47:00 -0700 Message-ID: <20130717074700.13d5152e@jbarnes-desktop> References: <20130714163009.22374.22100.stgit@zurg> <20130717062258.5467.69414.stgit@zurg> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from oproxy9.bluehost.com (oproxy9.bluehost.com [69.89.24.6]) by gabe.freedesktop.org (Postfix) with SMTP id D90BFE6104 for ; Wed, 17 Jul 2013 07:47:03 -0700 (PDT) In-Reply-To: <20130717062258.5467.69414.stgit@zurg> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Konstantin Khlebnikov Cc: rockorequin@hotmail.com, Daniel Vetter , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, alexkaltsas@gmail.com List-Id: dri-devel@lists.freedesktop.org On Wed, 17 Jul 2013 10:22:58 +0400 Konstantin Khlebnikov wrote: > This patch fixes regression in power consumtion of sandy bridge gpu, which > exists since v3.6 Sometimes after resuming from s2ram gpu starts thinking that > it's extremely busy. After that it never reaches rc6 state. > > Bug exists since kernel v3.6, commit b4ae3f22d238617ca11610b29fde16cf8c0bc6e0 > ("drm/i915: load boot context at driver init time"). > > For some reason RC6 is already enabled at the beginning of resuming process. > Following initliaztion breaks some internal state and confuses RPS engine. > This patch disables RC6 at the beginnig of resume and initialization. > > I've rearranged initialization sequence, because intel_disable_gt_powersave() > needs initialized force_wake_get/put and some locks from the dev_priv. > > References: https://bugs.freedesktop.org/show_bug.cgi?id=54089 > References: https://bugzilla.kernel.org/show_bug.cgi?id=58971 > Signed-off-by: Konstantin Khlebnikov > Cc: Daniel Vetter > Cc: Chris Wilson > Cc: Jesse Barnes > --- My hero! So the later init change didn't work? Either way, great to have this fix in the tree... thanks again. -- Jesse Barnes, Intel Open Source Technology Center