From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm: Don't generate invalid AVI infoframes for CEA modes Date: Mon, 5 Aug 2013 16:54:06 +0300 Message-ID: <20130805135406.GU5004@intel.com> References: <1375709807-11326-1-git-send-email-damien.lespiau@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mga14.intel.com (mga14.intel.com [143.182.124.37]) by gabe.freedesktop.org (Postfix) with ESMTP id BC915E702A for ; Mon, 5 Aug 2013 06:54:10 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1375709807-11326-1-git-send-email-damien.lespiau@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Damien Lespiau Cc: Thierry Reding , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On Mon, Aug 05, 2013 at 02:36:47PM +0100, Damien Lespiau wrote: > >From CEA-861: > = > Data Byte 1, bit A0 indicates whether Active Format Data is present in > Data Byte 2 bits R3 through R0. A source device shall set A0=3D1 when > any of the AFD bits are set. > = > ie. if we want to set active_aspect, we need to set the > active_info_valid bit to 1 as well. > = > Cc: Thierry Reding > Signed-off-by: Damien Lespiau Reviewed-by: Ville Syrj=E4l=E4 But why don't we just kill active_info_valid and instead just check active_aspect in hdmi_avi_infoframe_pack()? > --- > drivers/gpu/drm/drm_edid.c | 1 + > 1 file changed, 1 insertion(+) > = > diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c > index 95d6f4b..8d1139f 100644 > --- a/drivers/gpu/drm/drm_edid.c > +++ b/drivers/gpu/drm/drm_edid.c > @@ -3107,6 +3107,7 @@ drm_hdmi_avi_infoframe_from_display_mode(struct hdm= i_avi_infoframe *frame, > return 0; > = > frame->picture_aspect =3D HDMI_PICTURE_ASPECT_NONE; > + frame->active_info_valid =3D 1; > frame->active_aspect =3D HDMI_ACTIVE_ASPECT_PICTURE; > = > return 0; > -- = > 1.8.3.1 > = > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel -- = Ville Syrj=E4l=E4 Intel OTC