From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm: Don't generate invalid AVI infoframes for CEA modes Date: Mon, 5 Aug 2013 21:40:05 +0300 Message-ID: <20130805184005.GD5004@intel.com> References: <1375709807-11326-1-git-send-email-damien.lespiau@intel.com> <20130805180705.GA5004@intel.com> <20130805181827.GB19851@strange.amr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id 037A3E69DD for ; Mon, 5 Aug 2013 11:40:09 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20130805181827.GB19851@strange.amr.corp.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Damien Lespiau Cc: Thierry Reding , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On Mon, Aug 05, 2013 at 07:18:27PM +0100, Damien Lespiau wrote: > On Mon, Aug 05, 2013 at 09:07:05PM +0300, Ville Syrj=E4l=E4 wrote: > > On Mon, Aug 05, 2013 at 02:36:47PM +0100, Damien Lespiau wrote: > > > >From CEA-861: > > > = > > > Data Byte 1, bit A0 indicates whether Active Format Data is present= in > > > Data Byte 2 bits R3 through R0. A source device shall set A0=3D1 wh= en > > > any of the AFD bits are set. > > > = > > > ie. if we want to set active_aspect, we need to set the > > > active_info_valid bit to 1 as well. > > > = > > > Cc: Thierry Reding > > > Signed-off-by: Damien Lespiau > > > --- > > > drivers/gpu/drm/drm_edid.c | 1 + > > > 1 file changed, 1 insertion(+) > > > = > > > diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c > > > index 95d6f4b..8d1139f 100644 > > > --- a/drivers/gpu/drm/drm_edid.c > > > +++ b/drivers/gpu/drm/drm_edid.c > > > @@ -3107,6 +3107,7 @@ drm_hdmi_avi_infoframe_from_display_mode(struct= hdmi_avi_infoframe *frame, > > > return 0; > > = > > Nothing to do with this patch, but I just spotted this return here. So > > we're not populating the aspect ratio stuff if VIC=3D0. Doesn't really > > make sense to me. Who will tell me what this is trying to achieve? > = > I wondered about that to. The intent seems to not set those bits when > we're not setting a CEA mode. I guess the author thought that only CEA > modes can understand the infoframes described in CEA-861. I haven't > found any evidence of that, but made some sense to me. Perhaps. I'm leaning towards just killing that check though. -- = Ville Syrj=E4l=E4 Intel OTC