From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 1/3] drm: use common drm_gem_dmabuf_release in i915/exynos drivers Date: Wed, 7 Aug 2013 12:21:38 +0200 Message-ID: <20130807102138.GV22035@phenom.ffwll.local> References: <1375866908-5000-1-git-send-email-daniel.vetter@ffwll.ch> <1375866908-5000-2-git-send-email-daniel.vetter@ffwll.ch> <014c01ce9352$1e559690$5b00c3b0$%dae@samsung.com> <52021F05.6070401@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ea0-f169.google.com (mail-ea0-f169.google.com [209.85.215.169]) by gabe.freedesktop.org (Postfix) with ESMTP id E9B12E6FAA for ; Wed, 7 Aug 2013 03:21:32 -0700 (PDT) Received: by mail-ea0-f169.google.com with SMTP id z7so756101eaf.0 for ; Wed, 07 Aug 2013 03:21:31 -0700 (PDT) Content-Disposition: inline In-Reply-To: <52021F05.6070401@samsung.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Joonyoung Shim Cc: Daniel Vetter , Intel Graphics Development , DRI Development List-Id: dri-devel@lists.freedesktop.org On Wed, Aug 07, 2013 at 07:18:45PM +0900, Joonyoung Shim wrote: > On 08/07/2013 06:55 PM, Daniel Vetter wrote: > >On Wed, Aug 7, 2013 at 11:40 AM, Inki Dae wrote: > >>>-----Original Message----- > >>>From: Daniel Vetter [mailto:daniel.vetter@ffwll.ch] > >>>Sent: Wednesday, August 07, 2013 6:15 PM > >>>To: DRI Development > >>>Cc: Intel Graphics Development; Daniel Vetter; Inki Dae > >>>Subject: [PATCH 1/3] drm: use common drm_gem_dmabuf_release in i915/exynos > >>>drivers > >>> > >>>Note that this is slightly tricky since both drivers store their > >>>native objects in dma_buf->priv. But both also embed the base > >>>drm_gem_object at the first position, so the implicit cast is ok. > >>> > >>>To use the release helper we need to export it, too. > >>Yeah, may I repost this patch with additional work? We also need to export > >>with a gem object instead of specific one like you did. > > I think dmabuf stuff of exynos can be replaced to common drm_gem_dmabuf. > Already dmabuf stuff of drm_gem_cma_helper.c was substituted to common > drm_gem_dmabuf with low-level hook functions to use prime helpers. Ah, but that can easily be done on top of this, right? -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch