From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Ilia Mirkin <imirkin@alum.mit.edu>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v2] drm: use ida to allocate connector ids
Date: Wed, 7 Aug 2013 13:47:54 +0300 [thread overview]
Message-ID: <20130807104754.GS5004@intel.com> (raw)
In-Reply-To: <CAKb7UvjVxTYy_JOYppUnFT4hzrqgmdJ6bsMBTHp7LMt-9Z923Q@mail.gmail.com>
On Wed, Aug 07, 2013 at 04:28:35AM -0400, Ilia Mirkin wrote:
> On Wed, Aug 7, 2013 at 4:00 AM, Ville Syrjälä
> <ville.syrjala@linux.intel.com> wrote:
> > On Tue, Jul 30, 2013 at 03:51:49AM -0400, Ilia Mirkin wrote:
> >> @@ -722,8 +741,9 @@ int drm_connector_init(struct drm_device *dev,
> >> connector->dev = dev;
> >> connector->funcs = funcs;
> >> connector->connector_type = connector_type;
> >> - connector->connector_type_id =
> >> - ++drm_connector_enum_list[connector_type].count; /* TODO */
> >> + ret = ida_get_new_above(count, 1, &connector->connector_type_id);
> >> + if (ret)
> >> + goto out;
> >
> > Leak.
>
> I assume this is in reference to the drm_mode_object_get above? I just
> noticed that... or was there something else too?
Just the obj id.
--
Ville Syrjälä
Intel OTC
next prev parent reply other threads:[~2013-08-07 10:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-30 7:16 [PATCH] drm: use ida to allocate connector ids Ilia Mirkin
2013-07-30 7:51 ` [PATCH v2] " Ilia Mirkin
2013-08-07 0:12 ` Dave Airlie
2013-08-07 0:40 ` Rob Clark
2013-08-07 1:04 ` Ilia Mirkin
2013-08-07 8:00 ` Ville Syrjälä
2013-08-07 8:28 ` Ilia Mirkin
2013-08-07 8:40 ` Daniel Vetter
2013-08-07 10:47 ` Ville Syrjälä [this message]
2013-08-08 2:34 ` [PATCH v3] " Ilia Mirkin
2013-08-08 8:18 ` Ville Syrjälä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130807104754.GS5004@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=imirkin@alum.mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox