From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH] gma500: Fix SDVO turning off randomly
Date: Sun, 18 Aug 2013 20:05:33 +0200
Message-ID: <20130818180533.GK776@phenom.ffwll.local>
References: <1376118364-2232-1-git-send-email-gclement@baobob.org>
	<CAKMK7uEe=iAH3j7d+5JggrF9=ShuDKA2nEVzPAHtY2=hRe-ceA@mail.gmail.com>
	<20130810091937.GI3561@cantiga.alporthouse.com>
	<CAKMK7uE7LmUxo4DmEWAoVQe0VWXeh2PvHPb3TVwNq9mRtksmVQ@mail.gmail.com>
	<20130810194019.GB1934@thor.baobob.org>
	<CAMeQTsZ=L=LrTBkpFA06kiuqVbFb0AVd_FVQJrPdu8huopQp_g@mail.gmail.com>
	<CAKMK7uH-uQjE9TqQNkKZyHw5_WbpYY_2gwD8oTsawB2ShEPThA@mail.gmail.com>
	<CAMeQTsasVUbxdt8AnpDg+zjV_YMFzK698tgMsR9wt5+Gica85A@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org>
Received: from mail-ea0-f169.google.com (mail-ea0-f169.google.com
	[209.85.215.169])
	by gabe.freedesktop.org (Postfix) with ESMTP id 05028E5EA3
	for <dri-devel@lists.freedesktop.org>;
	Sun, 18 Aug 2013 11:05:23 -0700 (PDT)
Received: by mail-ea0-f169.google.com with SMTP id k11so452589eaj.0
	for <dri-devel@lists.freedesktop.org>;
	Sun, 18 Aug 2013 11:05:22 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <CAMeQTsasVUbxdt8AnpDg+zjV_YMFzK698tgMsR9wt5+Gica85A@mail.gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
To: Patrik Jakobsson <patrik.r.jakobsson@gmail.com>
Cc: dri-devel <dri-devel@lists.freedesktop.org>
List-Id: dri-devel@lists.freedesktop.org

On Fri, Aug 16, 2013 at 02:23:35AM +0200, Patrik Jakobsson wrote:
> On Sun, Aug 11, 2013 at 12:00 PM, Daniel Vetter <daniel@ffwll.ch> wrote:
> > On Sat, Aug 10, 2013 at 10:12 PM, Patrik Jakobsson
> > <patrik.r.jakobsson@gmail.com> wrote:
> > If you take this opportunity to share a bit of code between gma500 and
> > i915 (the sdvo #defines header and maybe the sdvo i2c read/write and
> > cmd helpers) I'd be interested in such a patch. We probably need an
> > struct intel_sdvo_chip to abstract away a few things.
> > -Daniel
> 
> I'll take a look at it. Does i915 also have GMBUS and GPIOs spread out
> on different
> devices like the minnow? GPIOs seem to be accessed through LPC.

Hm, we always have the intel gmbus controller, but at different offsets.
In any case the abstraction provided by i2c_adapter should be more than
enough I hope. In drm/i915 we always use the bit-banging i2c encoder, but
such quirks are all handled within the i2c_adapter we pass to the
low-level sdvo i/o functions.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch