From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean-Francois Moine Subject: Re: [PATCH v2 4/8] drm/i2c: tda998x: prepare for video input configuration Date: Thu, 22 Aug 2013 08:53:13 +0200 Message-ID: <20130822085313.2e8b1ae6@armhf> References: <20130821202646.47af66a5@armhf> <20130821223605.GA6617@n2100.arm.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <20130821223605.GA6617@n2100.arm.linux.org.uk> Sender: linux-kernel-owner@vger.kernel.org To: Russell King - ARM Linux Cc: Sebastian Hesselbarth , dri-devel@lists.freedesktop.org, David Airlie , Darren Etheridge , Rob Clark , Daniel Vetter , linux-kernel@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org On Wed, 21 Aug 2013 23:36:05 +0100 Russell King - ARM Linux wrote: > > AFAIK, the TI boards have no "pin-swapped", nor has the Cubox (ther= e is > > no need to set the bit CFG_GRA_SWAPRB of the register LCD_SPU_DMA_C= TRL0 > > of the Dove lcd for RGB or YUV formats). > >=20 > > Which board needs a special VIP configuration? =20 >=20 > If you run the NXP driver, and then run this driver, things get messe= d > up - which has already been covered months ago when this patch was fi= rst > brought up. >=20 > It's there to ensure that the TDA998x is correctly configured no matt= er > what it's previous state is, and prevent the thing being fragile as h= ell. The NXP driver will never go to the mainline, so, I don't see the problem. If you want to use it to test some other drivers, you should better patch it instead of adding useless code in the TDA998x driver. > No, reset doesn't restore its settings, only a power cycle does. Sorry, all VIP control registers may be changed at any time and the change appears immediately (thank you for the /sys i2c_read/write). --=20 Ken ar c'henta=C3=B1 | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/