From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [patch -next] drm/prime: double lock typo Date: Sat, 24 Aug 2013 00:53:29 +0200 Message-ID: <20130823225329.GA26909@phenom.ffwll.local> References: <20130823204602.GA10229@elgon.mountain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20130823204602.GA10229@elgon.mountain> Sender: kernel-janitors-owner@vger.kernel.org To: Dan Carpenter Cc: David Airlie , dri-devel@lists.freedesktop.org, Daniel Vetter , kernel-janitors@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org On Fri, Aug 23, 2013 at 11:46:02PM +0300, Dan Carpenter wrote: > There is a typo so deadlocks on error instead of unlocking. > > Signed-off-by: Dan Carpenter > > diff --git a/drivers/gpu/drm/drm_prime.c b/drivers/gpu/drm/drm_prime.c > index 7ae2bfc..276d470 100644 > --- a/drivers/gpu/drm/drm_prime.c > +++ b/drivers/gpu/drm/drm_prime.c > @@ -552,7 +552,7 @@ fail: > */ > drm_gem_handle_delete(file_priv, *handle); > out_unlock: > - mutex_lock(&dev->object_name_lock); > + mutex_unlock(&dev->object_name_lock); Duh. Unfortunately exercising error paths is pretty hard :( So thanks for catching this. Reviewed-by: Daniel Vetter -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch