From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: re: drm/radeon: add audio support for DCE6/8 GPUs (v12) Date: Tue, 3 Sep 2013 12:24:00 +0300 Message-ID: <20130903092400.GA4758@elgon.mountain> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from aserp1040.oracle.com (aserp1040.oracle.com [141.146.126.69]) by gabe.freedesktop.org (Postfix) with ESMTP id 87B3EE696B for ; Tue, 3 Sep 2013 02:24:11 -0700 (PDT) Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: alexander.deucher@amd.com Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org Hello Alex Deucher, This is a semi-automatic email about new static checker warnings. The patch b530602fd462: "drm/radeon: add audio support for DCE6/8 GPUs (v12)" from Jul 31, 2013, leads to the following Smatch complaint: drivers/gpu/drm/radeon/dce6_afmt.c:91 dce6_afmt_select_pin() warn: variable dereferenced before check 'dig->afmt->pin' (see line 89) drivers/gpu/drm/radeon/dce6_afmt.c 88 u32 offset = dig->afmt->offset; 89 u32 id = dig->afmt->pin->id; ^^^^^^^^^^^^^^^^^^ Patch adds dereference. 90 91 if (!dig->afmt->pin) ^^^^^^^^^^^^^^^ Patch adds check. 92 return; 93 regards, dan carpenter