[PATCH] drm: Fix kerneldoc of drm_crtc_convert_umode()

[PATCH] drm: Fix kerneldoc of drm_crtc_convert_umode()

[Damien Lespiau]

>From the copy and paste of drm_crtc_convert_to_umode()'s kerneldoc,
forgetting to update the symbol name (and they look so similar!).

Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
---
 drivers/gpu/drm/drm_crtc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c
index e92de2e..81046be 100644
--- a/drivers/gpu/drm/drm_crtc.c
+++ b/drivers/gpu/drm/drm_crtc.c
@@ -1290,7 +1290,7 @@ static void drm_crtc_convert_to_umode(struct drm_mode_modeinfo *out,
 }
 
 /**
- * drm_crtc_convert_to_umode - convert a modeinfo into a drm_display_mode
+ * drm_crtc_convert_umode - convert a modeinfo into a drm_display_mode
  * @out: drm_display_mode to return to the user
  * @in: drm_mode_modeinfo to use
  *
-- 
1.8.3.1

Re: [PATCH] drm: Fix kerneldoc of drm_crtc_convert_umode()

[Ville Syrjälä]

On Thu, Sep 05, 2013 at 02:40:44PM +0100, Damien Lespiau wrote:
> >From the copy and paste of drm_crtc_convert_to_umode()'s kerneldoc,
> forgetting to update the symbol name (and they look so similar!).
> 
> Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>

Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Although maybe renaming to drm_crtc_convert_from_umode() might make the
difference easier to spot. But it's only used in one place only so it's
not a big deal.

> ---
>  drivers/gpu/drm/drm_crtc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c
> index e92de2e..81046be 100644
> --- a/drivers/gpu/drm/drm_crtc.c
> +++ b/drivers/gpu/drm/drm_crtc.c
> @@ -1290,7 +1290,7 @@ static void drm_crtc_convert_to_umode(struct drm_mode_modeinfo *out,
>  }
>  
>  /**
> - * drm_crtc_convert_to_umode - convert a modeinfo into a drm_display_mode
> + * drm_crtc_convert_umode - convert a modeinfo into a drm_display_mode
>   * @out: drm_display_mode to return to the user
>   * @in: drm_mode_modeinfo to use
>   *
> -- 
> 1.8.3.1
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Ville Syrjälä
Intel OTC