From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm: Fix kerneldoc of drm_crtc_convert_umode() Date: Thu, 5 Sep 2013 17:00:17 +0300 Message-ID: <20130905140017.GD11428@intel.com> References: <1378388444-16149-1-git-send-email-damien.lespiau@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id 69FE5E64E8 for ; Thu, 5 Sep 2013 07:00:24 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1378388444-16149-1-git-send-email-damien.lespiau@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Damien Lespiau Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On Thu, Sep 05, 2013 at 02:40:44PM +0100, Damien Lespiau wrote: > >From the copy and paste of drm_crtc_convert_to_umode()'s kerneldoc, > forgetting to update the symbol name (and they look so similar!). > = > Signed-off-by: Damien Lespiau Reviewed-by: Ville Syrj=E4l=E4 Although maybe renaming to drm_crtc_convert_from_umode() might make the difference easier to spot. But it's only used in one place only so it's not a big deal. > --- > drivers/gpu/drm/drm_crtc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > = > diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c > index e92de2e..81046be 100644 > --- a/drivers/gpu/drm/drm_crtc.c > +++ b/drivers/gpu/drm/drm_crtc.c > @@ -1290,7 +1290,7 @@ static void drm_crtc_convert_to_umode(struct drm_mo= de_modeinfo *out, > } > = > /** > - * drm_crtc_convert_to_umode - convert a modeinfo into a drm_display_mode > + * drm_crtc_convert_umode - convert a modeinfo into a drm_display_mode > * @out: drm_display_mode to return to the user > * @in: drm_mode_modeinfo to use > * > -- = > 1.8.3.1 > = > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel -- = Ville Syrj=E4l=E4 Intel OTC