From: Markus Trippelsdorf <markus-xp2qqqlHh3xzoYq+O6RWwA@public.gmane.org>
To: dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Cc: Alex Deucher
<alexdeucher-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
kexec-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
Eric Biederman <ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>
Subject: [PATCH 1/3] kexec: get rid of late printk
Date: Sun, 8 Sep 2013 14:10:27 +0200 [thread overview]
Message-ID: <20130908121027.GB360@x4> (raw)
In-Reply-To: <20130908120947.GA360@x4>
kexec calls:
printk(KERN_EMERG "Starting new kernel\n");
late before calling machine_shutdown().
However at this point the underlying fb device may have already been
shutdown. This causes the kernel to hang.
Fix by simply getting rid of the printk call.
Signed-off-by: Markus Trippelsdorf <markus-xp2qqqlHh3xzoYq+O6RWwA@public.gmane.org>
---
kernel/kexec.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/kernel/kexec.c b/kernel/kexec.c
index 59f7b55..f33fa9f 100644
--- a/kernel/kexec.c
+++ b/kernel/kexec.c
@@ -1679,7 +1679,6 @@ int kernel_kexec(void)
#endif
{
kernel_restart_prepare(NULL);
- printk(KERN_EMERG "Starting new kernel\n");
machine_shutdown();
}
--
Markus
next prev parent reply other threads:[~2013-09-08 12:10 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-08 12:09 [PATCH 0/3] drm/radeon kexec fixes Markus Trippelsdorf
2013-09-08 12:10 ` Markus Trippelsdorf [this message]
2013-09-08 20:11 ` [PATCH 1/3] kexec: get rid of late printk Daniel Vetter
[not found] ` <CAKMK7uHa+uNAW-d=Tj5d27dkCqhZ0EJqyPThW3tK13bnVTbzjw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-09-08 20:42 ` Bruno Prémont
2013-09-08 12:10 ` [PATCH 2/3] drm/radeon: Implement radeon_pci_shutdown Markus Trippelsdorf
2013-09-09 13:32 ` Konrad Rzeszutek Wilk
2013-09-08 12:11 ` [PATCH 3/3] drm/radeon: get rid of r100_restore_sanity hack Markus Trippelsdorf
2013-09-09 0:32 ` [PATCH 0/3] drm/radeon kexec fixes Eric W. Biederman
[not found] ` <87bo42eswi.fsf-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>
2013-09-09 9:21 ` Markus Trippelsdorf
2013-09-09 9:38 ` Christian König
[not found] ` <522D972D.5090805-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org>
2013-09-11 9:01 ` Markus Trippelsdorf
2013-09-11 9:10 ` Christian König
2013-09-11 13:30 ` Alex Deucher
2013-09-09 13:04 ` Alex Deucher
[not found] ` <CADnq5_Oyd0hyr+WFYuA=a9Pa3i2e_ZY+Oc7LPawn8gSz3KPHUA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-09-10 18:27 ` Eric W. Biederman
[not found] ` <87ppsg8rbk.fsf-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>
2013-09-10 20:40 ` Alex Deucher
2013-09-11 8:53 ` Markus Trippelsdorf
2013-09-11 9:21 ` Christian König
2013-09-11 13:40 ` Alex Deucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130908121027.GB360@x4 \
--to=markus-xp2qqqlhh3xzoyq+o6rwwa@public.gmane.org \
--cc=alexdeucher-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org \
--cc=kexec-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox