From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 10/12] drm: Don't allow multiple buffers fb with stereo modes Date: Tue, 17 Sep 2013 12:54:09 +0300 Message-ID: <20130917095409.GR4531@intel.com> References: <1379353735-4472-1-git-send-email-damien.lespiau@intel.com> <1379353735-4472-11-git-send-email-damien.lespiau@intel.com> <20130917082046.GP4531@intel.com> <20130917090312.GG29268@strange.amr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Content-Disposition: inline In-Reply-To: <20130917090312.GG29268@strange.amr.corp.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Damien Lespiau Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On Tue, Sep 17, 2013 at 10:03:12AM +0100, Damien Lespiau wrote: > On Tue, Sep 17, 2013 at 11:20:46AM +0300, Ville Syrj=E4l=E4 wrote: > > +++ b/drivers/gpu/drm/drm_crtc.c > > > @@ -2131,6 +2131,17 @@ int drm_mode_setcrtc(struct drm_device *dev, v= oid *data, > > > goto out; > > > } > > > = > > > + /* > > > + * Do not allow the use of framebuffers consisting of multiple > > > + * buffers with stereo modes until all the details API details > > > + * are fleshed out (eg. interaction with drm_planes, switch > > > + * between a 1 buffers and a 2 buffers fb, ...) > > > + */ > > > + if (fb->num_buffers > 1 && drm_mode_is_stereo(mode)) { > > > + ret =3D -EINVAL; > > > + goto out; > > > + } > > = > > This would prevent planar buffers in stereo modes. I'm think we just > > ignore the matter for now and let drivers deal with it. We don't have > > enough handles anyway for planar stereo, so maybe we even want to add > > separate left/right fb attachment properties to the planes instead of > > tying it up in inside a single fb. Or we cook up addfb3 when we hit > > this problem for real. I think we'd anyway need some kind of flag for > > the fb if it contains both left and right buffers. > = > I'm quite happy to ignore 3 planes YUV stereo fbs for now :) (2 planes > YUV stereo fbs still fit!). > = > Are you fine with this test though, or do you mean ignore the whole > matter of forbidding this case (or just the multiplane stereo fb case)? > I was just thinking that I missed the addition of this check in the page > flip ioctl. Yeah, I was thinking we that we can ignore this issue for now, and so we wouldn't need the check. Currently for non-stereo cases the only thing we check is that there is a valid handle for each plane. If userspace passes more handles, we simply ignore the extra ones. -- = Ville Syrj=E4l=E4 Intel OTC