From: Al Viro <viro@ZenIV.linux.org.uk>
To: YoungJun Cho <yj44.cho@samsung.com>
Cc: dri-devel@lists.freedesktop.org
Subject: [RFC] deadlock in "drm/exynos: fix wrong pointer access at vm close"
Date: Sun, 22 Sep 2013 22:29:11 +0100 [thread overview]
Message-ID: <20130922212911.GU13318@ZenIV.linux.org.uk> (raw)
You have drm_dev->struct_mutex grabbed before ->mmap_sem in
exynos_drm_gem_mmap_ioctl() and after - in exynos_drm_gem_fault()
(since ->fault() is always called with ->mmap_sem held). Looks like
a garden-variety AB-BA deadlock...
Incidentally, what should happen if another process shares the
same opened file (e.g. inherited over fork()) and does mmap() just
as we have ->f_op switched?
next reply other threads:[~2013-09-22 22:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-22 21:29 Al Viro [this message]
2013-09-23 7:49 ` [RFC] deadlock in "drm/exynos: fix wrong pointer access at vm close" Inki Dae
2013-09-23 13:07 ` Al Viro
2013-09-24 4:41 ` Inki Dae
2013-09-26 3:26 ` Al Viro
2013-09-28 17:17 ` Inki Dae
2013-09-25 4:34 ` Inki Dae
2013-09-26 3:28 ` Al Viro
2013-09-28 17:47 ` Inki Dae
2013-09-28 17:50 ` Inki Dae
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130922212911.GU13318@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=dri-devel@lists.freedesktop.org \
--cc=yj44.cho@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).