From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm: Fix comment referring to the long gone ->probe() connector vfunc Date: Tue, 24 Sep 2013 12:33:50 +0200 Message-ID: <20130924103350.GL13668@phenom.ffwll.local> References: <1379944089-1622-1-git-send-email-damien.lespiau@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ee0-f41.google.com (mail-ee0-f41.google.com [74.125.83.41]) by gabe.freedesktop.org (Postfix) with ESMTP id 025D8E7210 for ; Tue, 24 Sep 2013 03:33:33 -0700 (PDT) Received: by mail-ee0-f41.google.com with SMTP id d17so2387105eek.28 for ; Tue, 24 Sep 2013 03:33:33 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1379944089-1622-1-git-send-email-damien.lespiau@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Damien Lespiau Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On Mon, Sep 23, 2013 at 02:48:09PM +0100, Damien Lespiau wrote: > drm_helper_probe_single_connector_modes() can be used to implement > ->fill_modes(), not ->probe(). > > Signed-off-by: Damien Lespiau Reviewed-by: Daniel Vetter > --- > drivers/gpu/drm/drm_crtc_helper.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/drm_crtc_helper.c b/drivers/gpu/drm/drm_crtc_helper.c > index 4280e37..5fcb9d4 100644 > --- a/drivers/gpu/drm/drm_crtc_helper.c > +++ b/drivers/gpu/drm/drm_crtc_helper.c > @@ -109,9 +109,9 @@ static void drm_mode_validate_flag(struct drm_connector *connector, > * then culled (based on validity and the @maxX, @maxY parameters) and put into > * the normal modes list. > * > - * Intended to be use as a generic implementation of the ->probe() @connector > - * callback for drivers that use the crtc helpers for output mode filtering and > - * detection. > + * Intended to be use as a generic implementation of the ->fill_modes() > + * @connector vfunc for drivers that use the crtc helpers for output mode > + * filtering and detection. > * > * RETURNS: > * Number of modes found on @connector. > -- > 1.8.3.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch