From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Chinner Subject: Re: [PATCH] drm/i915: Fix up usage of SHRINK_STOP Date: Thu, 26 Sep 2013 08:26:38 +1000 Message-ID: <20130925222638.GI26872@dastard> References: <1380110402-24749-1-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1380110402-24749-1-git-send-email-daniel.vetter@ffwll.ch> Sender: owner-linux-mm@kvack.org To: Daniel Vetter Cc: Intel Graphics Development , DRI Development , Linux MM , Knut Petersen , Glauber Costa , Glauber Costa , Andrew Morton , Rik van Riel , Mel Gorman , Johannes Weiner , Michal Hocko List-Id: dri-devel@lists.freedesktop.org On Wed, Sep 25, 2013 at 02:00:02PM +0200, Daniel Vetter wrote: > In > > commit 81e49f811404f428a9d9a63295a0c267e802fa12 > Author: Glauber Costa > Date: Wed Aug 28 10:18:13 2013 +1000 > > i915: bail out earlier when shrinker cannot acquire mutex > > SHRINK_STOP was added to tell the core shrinker code to bail out and > go to the next shrinker since the i915 shrinker couldn't acquire > required locks. But the SHRINK_STOP return code was added to the > ->count_objects callback and not the ->scan_objects callback as it > should have been, resulting in tons of dmesg noise like > > shrink_slab: i915_gem_inactive_scan+0x0/0x9c negative objects to delete nr=-xxxxxxxxx > > Fix discusssed with Dave Chinner. Acked-by: Dave Chinner Cheers, Dave. -- Dave Chinner david@fromorbit.com -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org