From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [RFCv1 02/12] drm: add object property type Date: Mon, 7 Oct 2013 16:43:35 +0300 Message-ID: <20131007134335.GI9395@intel.com> References: <1381020350-1125-1-git-send-email-robdclark@gmail.com> <1381020350-1125-3-git-send-email-robdclark@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id 5B3A3E6C15 for ; Mon, 7 Oct 2013 06:43:39 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1381020350-1125-3-git-send-email-robdclark@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Rob Clark Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On Sat, Oct 05, 2013 at 08:45:40PM -0400, Rob Clark wrote: > diff --git a/include/uapi/drm/drm_mode.h b/include/uapi/drm/drm_mode.h > index 5508117..35921ba 100644 > --- a/include/uapi/drm/drm_mode.h > +++ b/include/uapi/drm/drm_mode.h > @@ -231,6 +231,7 @@ struct drm_mode_get_connector { > #define DRM_MODE_PROP_ENUM (1<<3) /* enumerated type with text strings */ > #define DRM_MODE_PROP_BLOB (1<<4) > #define DRM_MODE_PROP_BITMASK (1<<5) /* bitmask of enumerated types */ > +#define DRM_MODE_PROP_OBJECT (1<<6) /* drm mode object */ This way to using up one bit for each type sucks big time. IIRC we discussed this at Fosdem and one idea was to leave the current bits as sort of base types, and reserve a bunch of the other bits to indicate a sub-type. For instance the new signed range and object ID prop types could be sub-types of the current range type. Maybe we should reserve a few more bits for new base types in case we need them in the future, or just add sometime king DRM_MODE_PROP_MISC, which is where we'd stick every sub-type that doesn't fit the current base types. -- = Ville Syrj=E4l=E4 Intel OTC