From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Paulo Zanoni <przanoni@gmail.com>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
Paulo Zanoni <paulo.r.zanoni@intel.com>,
DRI Development <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH 3/5] tty/vt: add con_bind and con_unbind functions
Date: Wed, 9 Oct 2013 11:10:32 +0300 [thread overview]
Message-ID: <20131009081032.GA13047@intel.com> (raw)
In-Reply-To: <CA+gsUGQrvjsoH_5rs38B+o=WbSkJNFZd4C+GdTKQaCenGNMX4A@mail.gmail.com>
On Tue, Oct 08, 2013 at 06:12:15PM -0300, Paulo Zanoni wrote:
> 2013/10/1 Ville Syrjälä <ville.syrjala@linux.intel.com>:
> > On Thu, Sep 26, 2013 at 08:06:00PM -0300, Paulo Zanoni wrote:
> >> From: Paulo Zanoni <paulo.r.zanoni@intel.com>
> >>
> >> The consoles who need to do something when unbinding or binding can
> >> optionally implement these functions.
> >>
> >> The current problem I'm trying to solve is that when i915+fbcon is
> >> loaded on Haswell, if we disable the power well (to save power) the
> >> VGA interface gets completely disabled, so when we unbind fbcon we
> >> need to restore the VGA interface to allow vgacon to work.
> >
> > We don't need to make it work. No one else does, and in the general case
> > it's even impossible since on some hardware that would definitely
> > corrupt the state that the real driver is attempting to use. The only
> > case where it might be nice to restore vgacon is on i915 unload, but no
> > one else does that either AFAIK, so I would not waste any cycles on
> > attempting that.
>
> I don't understand your point. Without patches 3-4-5, module_reload
> doesn't work at all if the power well is disabled: we need these
> patches to fix it. The plan is not to restore everything to make
> vgacon actually work, the plan is just to prevent it from breaking
> module_reload.
How does the power well vs. vgacon break module_reload?
BTW module_reload seems to be busted on ILK and IVB too currently.
--
Ville Syrjälä
Intel OTC
next prev parent reply other threads:[~2013-10-09 8:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-26 23:05 [PATCH 0/5] module_reload fixes Paulo Zanoni
2013-09-26 23:05 ` [PATCH 1/5] drm/i915: redisable VGA when we disable the power well Paulo Zanoni
2013-10-01 13:47 ` Ville Syrjälä
2013-10-01 18:18 ` Ville Syrjälä
2013-09-26 23:05 ` [PATCH 2/5] drm/i915: destroy connector sysfs files earlier Paulo Zanoni
2013-09-30 21:10 ` Daniel Vetter
2013-09-26 23:06 ` [PATCH 3/5] tty/vt: add con_bind and con_unbind functions Paulo Zanoni
2013-10-01 13:50 ` Ville Syrjälä
2013-10-08 21:12 ` Paulo Zanoni
2013-10-09 8:10 ` Ville Syrjälä [this message]
2013-09-26 23:06 ` [PATCH 4/5] console/fbcon: implement con_bind and con_unbind Paulo Zanoni
2013-09-26 23:06 ` [PATCH 5/5] drm/i915: put/get the power well at the FB bind/unbind functions Paulo Zanoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131009081032.GA13047@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=paulo.r.zanoni@intel.com \
--cc=przanoni@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).