From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 3/5] tty/vt: add con_bind and con_unbind functions Date: Wed, 9 Oct 2013 11:10:32 +0300 Message-ID: <20131009081032.GA13047@intel.com> References: <1380236762-1698-1-git-send-email-przanoni@gmail.com> <1380236762-1698-4-git-send-email-przanoni@gmail.com> <20131001135056.GM9395@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Paulo Zanoni Cc: Intel Graphics Development , Paulo Zanoni , DRI Development List-Id: dri-devel@lists.freedesktop.org On Tue, Oct 08, 2013 at 06:12:15PM -0300, Paulo Zanoni wrote: > 2013/10/1 Ville Syrj=E4l=E4 : > > On Thu, Sep 26, 2013 at 08:06:00PM -0300, Paulo Zanoni wrote: > >> From: Paulo Zanoni > >> > >> The consoles who need to do something when unbinding or binding can > >> optionally implement these functions. > >> > >> The current problem I'm trying to solve is that when i915+fbcon is > >> loaded on Haswell, if we disable the power well (to save power) the > >> VGA interface gets completely disabled, so when we unbind fbcon we > >> need to restore the VGA interface to allow vgacon to work. > > > > We don't need to make it work. No one else does, and in the general case > > it's even impossible since on some hardware that would definitely > > corrupt the state that the real driver is attempting to use. The only > > case where it might be nice to restore vgacon is on i915 unload, but no > > one else does that either AFAIK, so I would not waste any cycles on > > attempting that. > = > I don't understand your point. Without patches 3-4-5, module_reload > doesn't work at all if the power well is disabled: we need these > patches to fix it. The plan is not to restore everything to make > vgacon actually work, the plan is just to prevent it from breaking > module_reload. How does the power well vs. vgacon break module_reload? BTW module_reload seems to be busted on ILK and IVB too currently. -- = Ville Syrj=E4l=E4 Intel OTC