From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Damien Lespiau <damien.lespiau@intel.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 1/4] drm: Constify struct drm_info_list * arguments
Date: Fri, 18 Oct 2013 15:40:04 +0300 [thread overview]
Message-ID: <20131018124004.GQ13047@intel.com> (raw)
In-Reply-To: <1382033396-1400-1-git-send-email-damien.lespiau@intel.com>
On Thu, Oct 17, 2013 at 07:09:53PM +0100, Damien Lespiau wrote:
> Those functions are just reading data from those pointers.
>
> Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
for the series.
> ---
> drivers/gpu/drm/drm_debugfs.c | 4 ++--
> include/drm/drmP.h | 9 +++++----
> 2 files changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_debugfs.c b/drivers/gpu/drm/drm_debugfs.c
> index a05087c..4813ff1 100644
> --- a/drivers/gpu/drm/drm_debugfs.c
> +++ b/drivers/gpu/drm/drm_debugfs.c
> @@ -84,7 +84,7 @@ static const struct file_operations drm_debugfs_fops = {
> * Create a given set of debugfs files represented by an array of
> * gdm_debugfs_lists in the given root directory.
> */
> -int drm_debugfs_create_files(struct drm_info_list *files, int count,
> +int drm_debugfs_create_files(const struct drm_info_list *files, int count,
> struct dentry *root, struct drm_minor *minor)
> {
> struct drm_device *dev = minor->dev;
> @@ -188,7 +188,7 @@ int drm_debugfs_init(struct drm_minor *minor, int minor_id,
> *
> * Remove all debugfs entries created by debugfs_init().
> */
> -int drm_debugfs_remove_files(struct drm_info_list *files, int count,
> +int drm_debugfs_remove_files(const struct drm_info_list *files, int count,
> struct drm_minor *minor)
> {
> struct list_head *pos, *q;
> diff --git a/include/drm/drmP.h b/include/drm/drmP.h
> index 2b954ad..c3b659a 100644
> --- a/include/drm/drmP.h
> +++ b/include/drm/drmP.h
> @@ -1470,10 +1470,11 @@ extern struct drm_local_map *drm_getsarea(struct drm_device *dev);
> #if defined(CONFIG_DEBUG_FS)
> extern int drm_debugfs_init(struct drm_minor *minor, int minor_id,
> struct dentry *root);
> -extern int drm_debugfs_create_files(struct drm_info_list *files, int count,
> - struct dentry *root, struct drm_minor *minor);
> -extern int drm_debugfs_remove_files(struct drm_info_list *files, int count,
> - struct drm_minor *minor);
> +extern int drm_debugfs_create_files(const struct drm_info_list *files,
> + int count, struct dentry *root,
> + struct drm_minor *minor);
> +extern int drm_debugfs_remove_files(const struct drm_info_list *files,
> + int count, struct drm_minor *minor);
> extern int drm_debugfs_cleanup(struct drm_minor *minor);
> #endif
>
> --
> 1.8.3.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Ville Syrjälä
Intel OTC
prev parent reply other threads:[~2013-10-18 12:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-17 18:09 [PATCH 1/4] drm: Constify struct drm_info_list * arguments Damien Lespiau
2013-10-17 18:09 ` [PATCH 2/4] drm: Remove drm_debugfs_node and drm_debugfs_list Damien Lespiau
2013-10-17 18:09 ` [PATCH 3/4] drm: Make drm_debugfs_list const Damien Lespiau
2013-10-17 18:09 ` [PATCH 4/4] drm/i915: Make the debugfs structures const Damien Lespiau
2013-10-18 12:40 ` Ville Syrjälä [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131018124004.GQ13047@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=damien.lespiau@intel.com \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox