dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Roskin <proski@gnu.org>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm: Restrict ioctl size to kernel struct size
Date: Tue, 22 Oct 2013 11:57:49 -0400	[thread overview]
Message-ID: <20131022115749.03199f11@IRBT4585> (raw)
In-Reply-To: <1382434683-32048-1-git-send-email-chris@chris-wilson.co.uk>

On Tue, 22 Oct 2013 10:38:03 +0100
Chris Wilson <chris@chris-wilson.co.uk> wrote:

> Prevent the user from passing in an ioctl command with up to 16,383
> bytes specified for the struct to be allocated and copied, and
> instead only allocate enough space to satisfy the kernel.
> 
> Suggested-by: Pavel Roskin <proski@gnu.org>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Pavel Roskin <proski@gnu.org>
> Cc: dri-devel@lists.freedesktop.org

Thank you for taking care of that!

Reviewed-by: Pavel Roskin <proski@gnu.org>

-- 
Regards,
Pavel Roskin

      parent reply	other threads:[~2013-10-22 15:57 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-17  0:12 [PATCH] drm: never write to the userspace more data than the caller wants Pavel Roskin
2013-10-17 12:26 ` Chris Wilson
2013-10-17 14:58   ` Pavel Roskin
2013-10-22  9:38 ` [PATCH] drm: Restrict ioctl size to kernel struct size Chris Wilson
2013-10-22 10:40   ` Ville Syrjälä
2013-10-22 15:57   ` Pavel Roskin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131022115749.03199f11@IRBT4585 \
    --to=proski@gnu.org \
    --cc=chris@chris-wilson.co.uk \
    --cc=dri-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox