From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: Vblank timestamping improvements/fixes for Linux
	drm.
Date: Mon, 28 Oct 2013 13:08:20 +0200
Message-ID: <20131028110820.GP13047@intel.com>
References: <1382776062-3770-1-git-send-email-mario.kleiner.de@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Content-Disposition: inline
In-Reply-To: <1382776062-3770-1-git-send-email-mario.kleiner.de@gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Mario Kleiner <mario.kleiner.de@gmail.com>
Cc: alexdeucher@gmail.com, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org

On Sat, Oct 26, 2013 at 10:27:38AM +0200, Mario Kleiner wrote:
> Hi all,
> =

> this patch set for the kernel pushes the latency sensitive bits of
> vblank scanoutpos timestamping from the drm core into the kms drivers.
> =

> A change in the locking of the intel-kms driver for Linux 3.11 made
> the old approach too inaccurate and also incompatible with the
> PREEMPT_RT realtime kernel patch set. These patches fix that problem
> and restore the old level of precision and reliability.
> =

> The patch set changes the prototype of driver->get_scanout_position()
> to require/allow kms drivers to perform the ktime_get() system time
> queries which go along with actual scanout position readout in a way
> that provides maximum precision and to return those timestamps to
> the drm. It also converts the only two kms drivers which use this api
> so far (intel-kms and radeon-kms) to the new api and improves precision
> and reliability of the intel-kms a lot.
> =

> Patches have been tested on Intel and AMD Radeon hardware and the Intel
> bits have received some review and feedback by Ville Syrj=E4l=E4.
> =

> Please review and apply if possible.

I only have a minor nit about the formatting of multiline comments.

They should look like:
/*
 * foo
 * bar
 */

instead of:
/* foo
 * bar
 */

But other than that I didn't spot any issues, so for the series:

Reviewed-by: Ville Syrj=E4l=E4 <ville.syrjala@linux.intel.com>

-- =

Ville Syrj=E4l=E4
Intel OTC