From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH v2 12/26] drm/exynos: Split manager/display/subdrv Date: Mon, 4 Nov 2013 11:08:19 +0100 Message-ID: <20131104100818.GH27445@ulmo.nvidia.com> References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1382294984==" Return-path: Received: from mail-bk0-f53.google.com (mail-bk0-f53.google.com [209.85.214.53]) by gabe.freedesktop.org (Postfix) with ESMTP id CD2A413130E for ; Mon, 4 Nov 2013 02:08:23 -0800 (PST) Received: by mail-bk0-f53.google.com with SMTP id w11so2209705bkz.40 for ; Mon, 04 Nov 2013 02:08:22 -0800 (PST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org To: Dave Airlie Cc: =?utf-8?B?U3TDqXBoYW5l?= Marchesin , dri-devel List-Id: dri-devel@lists.freedesktop.org --===============1382294984== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="QDd5rp1wjxlDmy9q" Content-Disposition: inline --QDd5rp1wjxlDmy9q Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Oct 23, 2013 at 04:22:11PM +0100, Dave Airlie wrote: > On Wed, Oct 23, 2013 at 3:45 PM, Sean Paul wrote: > > On Wed, Oct 23, 2013 at 10:29 AM, Dave Airlie wrote: > >>> As I mentioned earlier, display_ops is needed to have no any > >>> dependency of drm framework directly like below, > >>> > >>> DRM Framework > >>> | > >>> Exynos DRM Framework > >>> / | \ > >>> Real device drivers > >>> > >>> In particular, in case of ARM based DRM drivers with separated > >>> devices, I still tend to think it's better design than that device > >>> drivers implement the connector callbacks directly, but I will try to > >>> consider what is the better way. > >>> > >> > >> I think we need to start considering a framework where subdrivers just > >> add drm objects themselves, then the toplevel node is responsible for > >> knowing that everything for the current configuration is loaded. > >> > > > > It would be nice to specify the various pieces in dt, then have some > > type of drm notifier to the toplevel node when everything has been > > probed. Doing it in the dt would allow standalone drm_bridge/drm_panel > > drivers to be transparent as far as the device's drm driver is > > concerned. > > > > Sean > > > > > >> I realise we may need to make changes to the core drm to allow this > >> but we should probably start to create a strategy for fixing the API > >> issues that this throws up. > >> > >> Note I'm not yet advocating for dynamic addition of nodes once the > >> device is in use, or removing them. > >> >=20 > I do wonder if we had some sort of tag in the device tree for any nodes > involved in the display, and the core drm layer would read that list, > and when every driver registers tick things off, and when the last one > joins we get a callback and init the drm layer, we'd of course have the > basic drm layer setup prior to that so we can add the objects as the > drivers load. It might make development a bit trickier as you'd need > to make sure someone claimed ownership of all the bits for init to procee= d. I'm curious whether anyone actually ever bothered to look at the Tegra driver. It pretty much does all of this already. Granted the hardware may be more friendly than on most other SoCs, but essentially the problem is the same. Thierry --QDd5rp1wjxlDmy9q Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJSd3ISAAoJEN0jrNd/PrOhIW4QAJ9/yL6PrW1ZB6fB5t3TpV+q r8AJpvB0Ujr9RHxBEMsSXpFHIK0IDdvCRyp78eeT1W+5wxTrw8jpM708vjoloFP1 XubxVKDRbYw5OknmhGj6hsJb33xuog/BWxncj84vV/pc7q7KunWxbajmd/VyjgSG jmZQn4JzLDCWbW/wDMiTn7Z1QuWqV076+DbuUrigS7Tzz+t3M7dlBvwWBE4gzmDF dtBvCaCdIf6U537I0miSpf3oX0BfDWQD9WH2gCkNjL1pjizHIHTaMEOXzQBgUjtj tUjsoAKafhN/OBU1ynaJLPTpFXQhdQRNjq31+NaG11lRXhkoDucLoTelnpGYn9Ep F8CRGyKnb75goTmMZusefpZn+M7v92bJigDxNphTo74Ia/8jJbkgUk/+e3eznRzu mff2iVv3mPH/s8KNCT8S6N6HFDhJIkcSWIZMG0IppohNdf5fcXBRenGIRFEpbr4Y +C8Y0MOmMIyY/FFg2ypYdIg6Yi23J5C/3jEpbxF05g6FHhMSKl6jpCbxBjiYc+HL pyItQHgLm0vWRM/TIqSKGuWn3RpApNOCfpaUWYQgrUcdvlbZPc0e6ip4mDFERY4h vTqxbSfC2ieQDsO/wAA6XOs4Q7YfcbWxM64ESCJk7p0h4BQLzlYIMrclzp2688uZ Lazb/XcuXz5/oKb1krJN =Yjue -----END PGP SIGNATURE----- --QDd5rp1wjxlDmy9q-- --===============1382294984== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel --===============1382294984==--