From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH v3 13/32] drm/exynos: hdmi: remove the i2c drivers and use devtree Date: Mon, 11 Nov 2013 09:44:27 +0100 Message-ID: <20131111084426.GA3884@ulmo.nvidia.com> References: <1383063198-10526-1-git-send-email-seanpaul@chromium.org> <1383063198-10526-14-git-send-email-seanpaul@chromium.org> <3586522.SB7l1OESEl@flatron> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2014704954==" Return-path: Received: from mail-bk0-f49.google.com (mail-bk0-f49.google.com [209.85.214.49]) by gabe.freedesktop.org (Postfix) with ESMTP id B4D58FAC85 for ; Mon, 11 Nov 2013 00:44:39 -0800 (PST) Received: by mail-bk0-f49.google.com with SMTP id w14so1872331bkz.8 for ; Mon, 11 Nov 2013 00:44:38 -0800 (PST) In-Reply-To: <3586522.SB7l1OESEl@flatron> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org To: Tomasz Figa Cc: marcheu@chromium.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============2014704954== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="HlL+5n6rz5pIUxbD" Content-Disposition: inline --HlL+5n6rz5pIUxbD Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Nov 10, 2013 at 09:46:02PM +0100, Tomasz Figa wrote: [...] > On Tuesday 29 of October 2013 12:12:59 Sean Paul wrote: [...] > [snip] > > @@ -1957,21 +1943,30 @@ static int hdmi_probe(struct platform_device *p= dev) > > } > > =20 > > /* DDC i2c driver */ > > - if (i2c_add_driver(&ddc_driver)) { > > - DRM_ERROR("failed to register ddc i2c driver\n"); > > - return -ENOENT; > > + ddc_node =3D of_find_node_by_name(NULL, "hdmiddc"); >=20 > This is wrong. You shall not reference a device tree node by its name, > except some very specific well-defined cases, such as cpus or memory > nodes. >=20 > A solution closest to yours, but correct, would be to use the same match > table as in the I2C driver you are removing and call > of_find_matching_node(). Isn't the correct solution to use a phandle? That might need the binding to change in a backwards incompatible way. Then again, if something as simple as specifying a DDC I2C bus causes the binding to change in a backwards incompatible way then it can't have been a very good binding in the first place, right? +1 for unstable DT bindings... Thierry --HlL+5n6rz5pIUxbD Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJSgJjqAAoJEN0jrNd/PrOhis0P/iOY6KYAUAtagPpyLLsgTgch fgYLzMYAYoHCQUN2qcvQB1fPG4GzP2NrwLaXjXTNMc7ScM24d86Zkb1dkpruUixK g12SrBPBF5oMvyQCb9OnTZSjDnBp6xWrBnLYWSP8zPlVgJId1z0h2DQBae7nnXte Jku8p78P0oPD9Tttc3ICoQI1Vm4Jq4Sckw/3K9F/A7FpB5ShkRyI9HnknhLyymNw z6cHDh8qjHvr5S5eztfYX+4qpRKJvlWVtEjQHouSiIVKc+Z2q25jMNvQZfVZE+jb 2iMlSdg/32kMtW+0dbtUlE+lyPuTdyUPoblkY95tOtJvNMnm378WtXDvVRxsmcIa vrnlSdNXdXovXVE5XbkzEcLR18bKwelSRUspzv8NMkAIbSZP06aPEF6je1L70/bG hVN8J3zCtvE47ubYnE1RavsG7VefLuqxWAvpvo0TZot71hezHskKLsOUxDWU52l6 fhlkI2N+MzpLXwAgfbfFVCwSq7E4s0x4QN7n092oCOVD+hQceaUxn8Lv/VAHQE4s dYFxF/ORtRbKRQUaUhxKJZoG+jXJt9ywYdczjRgrVSl+bnV79NBlB4LotJBTJdmy H8/krWvdsed/bP11z3GYp6JquMA5kADw5072zIPvmCpPpdi/JB30Hq5cvmjzer95 wG91yWBG37pdWcaifsMf =omKt -----END PGP SIGNATURE----- --HlL+5n6rz5pIUxbD-- --===============2014704954== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel --===============2014704954==--