From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russell King - ARM Linux Subject: Re: [PATCH 1/3] drm: Add LCD display clock polarity flags Date: Mon, 2 Dec 2013 20:01:17 +0000 Message-ID: <20131202200117.GN16735@n2100.arm.linux.org.uk> References: <1385998768-23512-1-git-send-email-marex@denx.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1385998768-23512-1-git-send-email-marex@denx.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Marek Vasut Cc: devel@driverdev.osuosl.org, Greg Kroah-Hartman , Sascha Hauer , dri-devel@lists.freedesktop.org, Philipp Zabel , Shawn Guo , Dave Airlie , linux-arm-kernel@lists.infradead.org List-Id: dri-devel@lists.freedesktop.org On Mon, Dec 02, 2013 at 04:39:26PM +0100, Marek Vasut wrote: > Add DRM flags for the LCD display clock polarity so the pixelclk-active DT > property can be properly handled by drivers using the DRM API. I still say that not even this should be part of the DRM mode API to userspace. The hint that you're changing the user API is that you're modifying a header file below a 'uapi' directory. The settings of double scan, sync polarity etc are all part of the display mode specification (check CEA-861 documents). Things like pixel clock polarity are not part of the mode specification, they're a property of the display itself and are independent of the mode. Therefore, they should not be part of struct drm_mode_modeinfo.