From: Thierry Reding <thierry.reding@gmail.com>
To: Andrzej Hajda <a.hajda@samsung.com>
Cc: tomi.valkeinen@ti.com, Kyungmin Park <kyungmin.park@samsung.com>,
Thierry Reding <treding@nvidia.com>,
dri-devel@lists.freedesktop.org
Subject: Re: [RFC PATCH v3] mipi-dsi-bus: add MIPI DSI bus support
Date: Wed, 4 Dec 2013 16:59:00 +0100 [thread overview]
Message-ID: <20131204155859.GA21833@ulmo.nvidia.com> (raw)
In-Reply-To: <1386171312-8173-1-git-send-email-a.hajda@samsung.com>
[-- Attachment #1.1: Type: text/plain, Size: 1508 bytes --]
On Wed, Dec 04, 2013 at 04:35:12PM +0100, Andrzej Hajda wrote:
> MIPI DSI bus allows to model DSI hosts and DSI devices using Linux bus.
> DSI host should be registered by DSI master driver. During registration
> DSI devices will be created according to Device Tree sub-nodes,
> registration based on board info will be added later.
> DSI host exposes operations which can be used by slave drivers
> to access associated devices.
>
> Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
> Hi Thierry,
>
> This is the 3rd version of MIPI DSI bus patch.
> Most of changes comes from Thierry comments.
> The main difference is complete change of 'philosophy' behind it.
> In previous version DSI host could be standalone driver without DRM
> dependency. In the current version it should be DRM device.
> This change breaks my drivers so I cannot test this version of patch on live system yet.
From a brief glance this looks pretty good. I'll start porting the Tegra
DSI driver to this and report back.
> There are few things which still bother me:
> - DSI mode flags - some of them seems to be too specific for my HW,
> - other DSI parameters, probably there should be more, like max clock, supported pixel modes,....
I think both of those can be extended or cleaned up once we have a few
working drivers. No need to try and make it perfect right away, chances
are we'll get a few things wrong anyway.
Thierry
[-- Attachment #1.2: Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2013-12-04 15:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-04 15:35 [RFC PATCH v3] mipi-dsi-bus: add MIPI DSI bus support Andrzej Hajda
2013-12-04 15:59 ` Thierry Reding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131204155859.GA21833@ulmo.nvidia.com \
--to=thierry.reding@gmail.com \
--cc=a.hajda@samsung.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=kyungmin.park@samsung.com \
--cc=tomi.valkeinen@ti.com \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox