From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH v2 1/4] drm/dp: Add AUX channel infrastructure Date: Fri, 20 Dec 2013 15:33:54 +0100 Message-ID: <20131220143353.GA29708@ulmo.nvidia.com> References: <1387297207-7643-1-git-send-email-treding@nvidia.com> <1387297207-7643-2-git-send-email-treding@nvidia.com> <87a9fvk6uy.fsf@intel.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0719359322==" Return-path: Received: from mail-bk0-f44.google.com (mail-bk0-f44.google.com [209.85.214.44]) by gabe.freedesktop.org (Postfix) with ESMTP id 35F77FA30C for ; Fri, 20 Dec 2013 06:35:27 -0800 (PST) Received: by mail-bk0-f44.google.com with SMTP id d7so1235592bkh.3 for ; Fri, 20 Dec 2013 06:35:26 -0800 (PST) In-Reply-To: <87a9fvk6uy.fsf@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org To: Jani Nikula Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0719359322== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="XsQoSWH+UP9D9v3l" Content-Disposition: inline --XsQoSWH+UP9D9v3l Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Dec 20, 2013 at 03:08:21PM +0200, Jani Nikula wrote: > On Tue, 17 Dec 2013, Thierry Reding wrote: [...] > > +/** > > + * drm_dp_dpcd_writeb() - write a single byte to the DPCD > > + * @aux: DisplayPort AUX channel > > + * @offset: address of the register to write > > + * @valuep: value to write to the register > > + * > > + * Returns the number of bytes transferred (1) on success, or a negati= ve > > + * error code on failure. > > + */ > > +static inline ssize_t drm_dp_dpcd_writeb(struct drm_dp_aux *aux, u8 va= lue, > > + unsigned int offset) >=20 > I'd much prefer offset before value parameter. Why would you have these > the other way around here than in all the other functions? I guess I thought this would mirror the convention seen with readl() and writel(), but I suppose since drm_dp_dpcd_readb() doesn't actually look anything like readl() there's no consistency here anyway. I'll change it around. Thierry --XsQoSWH+UP9D9v3l Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJStFVRAAoJEN0jrNd/PrOhDVMP/2HDkjNe21DNGxfX2660mLde pZMcLyTQ8kCniqvrIYoXYLwUUwKDICu/KDZ45KqrV2gGnC7rZXzYjXY9I993yzQJ UWzO4n+FpX3++Yk9ySDANx/ic3VdAMRRL1Xpu0hmX4BlVXtpUWdbHroL5iT/wJtD OSDdRuh0skqZjHzzxJgsatB/rsd1ZJEKIKolmlag7GNJmn/xDmaEz26iyQssIrjk GAOMPW+BLb47P1Dmx3Vu0nVzZpGvaofpzYlU7N1Q4R/GW1/KEcet0tbwv6M5Ez2S elnY9i4f77Apny1Cqrrfb5QarOOmdlIscTwc0495wOwjPFQTQbXzaWbCE1eyHer0 iLx9O4XgfoiW2NESiWHRbmRiZlbrJy8WoHZp2PuH4iQ1UePZ+rqywK25U0lWaZ4M 6iRAvpigB53vIY+2eJTUkpI6ykDDbF7cL0l+IqHfRpjnOnK2D1Yyqm+rXKfX+RG8 XBwXfcMEkxUtpKxRy1xX5VirZEhjnfvdX731r+jYLjcZ53jhc/B9dxOPRmq492O7 tAuREuXe6+n6YF/bp9+xubiZT2OtR2A96LVZ3yNx+qN9yXMhBLTYLgIQ9jYp08aX /K5BFz5eVtNAihxi8yyRYtPI798CqxEtJ8b2LV3Rlv20JxQGMo6mTBhwORNjgXED 4wI+TJMa0gWD2f5aEi7U =0VR8 -----END PGP SIGNATURE----- --XsQoSWH+UP9D9v3l-- --===============0719359322== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel --===============0719359322==--