From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russell King - ARM Linux Subject: Re: [PATCH 1/2] drm: provide a helper for the encoder possible_crtcs mask Date: Mon, 13 Jan 2014 12:47:06 +0000 Message-ID: <20140113124706.GW15937@n2100.arm.linux.org.uk> References: <1389613610-21084-1-git-send-email-treding@nvidia.com> <1389613610-21084-2-git-send-email-treding@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from pandora.arm.linux.org.uk (gw-1.arm.linux.org.uk [78.32.30.217]) by gabe.freedesktop.org (Postfix) with ESMTP id 16AF510ED29 for ; Mon, 13 Jan 2014 04:47:15 -0800 (PST) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org To: David Herrmann Cc: Daniel Vetter , Intel Graphics Development , "dri-devel@lists.freedesktop.org" List-Id: dri-devel@lists.freedesktop.org On Mon, Jan 13, 2014 at 12:58:54PM +0100, David Herrmann wrote: > Does that -1 ever make sense? We don't support mode-object-hotplugging > so all "drm_crtc" objects are known at initialization time. I'd rather > put a BUG() here than a silent -1. This also makes drm_crtc_mask() > redundant. I disagree with that last statement. drm_crtc_mask() is still useful for converting to the mask, rather than having that open coded all over the place. It probably makes more sense for drm_crtc_mask() to become a helper in a header file though. -- FTTC broadband for 0.8mile line: 5.8Mbps down 500kbps up. Estimation in database were 13.1 to 19Mbit for a good line, about 7.5+ for a bad. Estimate before purchase was "up to 13.2Mbit".