From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russell King - ARM Linux Subject: Re: [PATCH v3 19/24] drm/i2c: tda998x: use global constants Date: Wed, 22 Jan 2014 23:29:22 +0000 Message-ID: <20140122232922.GP15937@n2100.arm.linux.org.uk> References: <20140119195845.13b8a0e9@armhf> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20140119195845.13b8a0e9@armhf> Sender: linux-kernel-owner@vger.kernel.org To: Jean-Francois Moine Cc: dri-devel@lists.freedesktop.org, Dave Airlie , Rob Clark , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org On Sun, Jan 19, 2014 at 07:58:45PM +0100, Jean-Francois Moine wrote: > Signed-off-by: Jean-Francois Moine Might be worth also saying "and tidy up AIP_CLKSEL" since arguably they were already using global constants. In any case, no one likes single line patch descriptions. Always try to write something more about the patch. I've verified this via inspection, and tested it. Tested-by: Russell King -- FTTC broadband for 0.8mile line: 5.8Mbps down 500kbps up. Estimation in database were 13.1 to 19Mbit for a good line, about 7.5+ for a bad. Estimate before purchase was "up to 13.2Mbit".