From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/doc: Clarify the dumb object interfaces Date: Fri, 24 Jan 2014 17:53:17 +0100 Message-ID: <20140124165317.GB9772@phenom.ffwll.local> References: <55621221.KeT6W6ykYc@avalon> <1390485025-16840-1-git-send-email-daniel.vetter@ffwll.ch> <8133797.MaFuyckv2B@avalon> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wg0-f42.google.com (mail-wg0-f42.google.com [74.125.82.42]) by gabe.freedesktop.org (Postfix) with ESMTP id 36EB1FAEEB for ; Fri, 24 Jan 2014 08:53:21 -0800 (PST) Received: by mail-wg0-f42.google.com with SMTP id l18so2075241wgh.3 for ; Fri, 24 Jan 2014 08:53:20 -0800 (PST) Content-Disposition: inline In-Reply-To: <8133797.MaFuyckv2B@avalon> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org To: Laurent Pinchart Cc: Daniel Vetter , DRI Development List-Id: dri-devel@lists.freedesktop.org On Fri, Jan 24, 2014 at 12:13:11PM +0100, Laurent Pinchart wrote: > Hi Daniel, > > Thank you for the patch. > > One last round of nitpicking (including a typo fix, which gives me an excuse > for a couple more comments :-)). > > On Thursday 23 January 2014 14:50:25 Daniel Vetter wrote: > > - This is _not_ a generic interface to create gem objects, but just an > > interface to make early boot services (like boot splash) with a > > generic KMS userspace driver possible. Hence it's better to move > > the documentation for this from the GEM section to the KMS section, > > next to the creation of framebuffer objects. > > > > - Make it really clear that the returned handle isn't necessarily a > > GEM object (it can also be e.g. a TTM handle when running on top of > > vmwgfx). > > > > - Add a paragraph to make it clear that this is just for unaccelarated > > userspace - gpu drivers need to have their own buffer object > > creation ioctl which is hardware specific. > > > > v2: Clarify that the documentation doesn't just apply to GEM-based > > drivers only but is now generally valid, as suggested by David. > > > > v3: Polish the intro sentence a bit and one s/objects/handles/ for > > clarification, both suggested by Laurent. > > > > Cc: David Herrmann > > Cc: Laurent Pinchart > > Signed-off-by: Daniel Vetter > > --- > > Documentation/DocBook/drm.tmpl | 129 ++++++++++++++++++++------------------ > > 1 file changed, 70 insertions(+), 59 deletions(-) > > > > diff --git a/Documentation/DocBook/drm.tmpl b/Documentation/DocBook/drm.tmpl > > index ed1d6d289022..767318d5ddb6 100644 > > --- a/Documentation/DocBook/drm.tmpl > > +++ b/Documentation/DocBook/drm.tmpl > > [snip] > > > @@ -1052,6 +998,71 @@ int max_width, max_height; > > drm_framebuffer_unregister_private. > > > > > > + Dumb GEM Objects > > What about calling this "Dumb Memory Objects" (or something similar), as > they're not specific to GEM ? I've gone through the entire section to remove all GEM-specific language and missed the title. That's some good fail right there ;-) I'm going with buffer objects, which I think is the most established language for gfx memory management - GL also uses it in specs. [snip] > > + attempted on some ARM embedded platforms. Such drivers really must have > > + a hardware-specific ioctl to allocate suitable objects. > > What about s/objects/memory objects/ ? "object" alone is rather vague for > people not too familiar with DRM/KMS. Also opted for buffer object here. Other suggestions applies unchaged. Thanks, Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch