From: Dave Jones <davej@redhat.com>
To: bskeggs@redhat.com
Cc: dri-devel@lists.freedesktop.org
Subject: nouveau: treat nv04_devinit_priv.owner as signed.
Date: Thu, 30 Jan 2014 12:21:05 -0500 [thread overview]
Message-ID: <20140130172105.GA1834@redhat.com> (raw)
This is set and compared to -1 in the code, which evaluates to always false.
If we want to treat it as a signed var, we should declare it as one.
Signed-off-by: Dave Jones <davej@fedoraproject.org>
diff --git a/drivers/gpu/drm/nouveau/core/subdev/devinit/nv04.h b/drivers/gpu/drm/nouveau/core/subdev/devinit/nv04.h
index 23470a57510c..9d54c106dddf 100644
--- a/drivers/gpu/drm/nouveau/core/subdev/devinit/nv04.h
+++ b/drivers/gpu/drm/nouveau/core/subdev/devinit/nv04.h
@@ -5,7 +5,7 @@
struct nv04_devinit_priv {
struct nouveau_devinit base;
- u8 owner;
+ s8 owner;
};
int nv04_devinit_ctor(struct nouveau_object *, struct nouveau_object *,
reply other threads:[~2014-01-30 17:21 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140130172105.GA1834@redhat.com \
--to=davej@redhat.com \
--cc=bskeggs@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox