From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russell King - ARM Linux Subject: Re: [PATCH] drm/i2c: tda998x: fix memory leak in case of i2c error Date: Thu, 13 Feb 2014 19:40:09 +0000 Message-ID: <20140213194009.GD30257@n2100.arm.linux.org.uk> References: <20140213083316.38D7D822BD@smtp6-g21.free.fr> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from pandora.arm.linux.org.uk (gw-1.arm.linux.org.uk [78.32.30.217]) by gabe.freedesktop.org (Postfix) with ESMTP id 5CBF7FB389 for ; Thu, 13 Feb 2014 11:40:21 -0800 (PST) Content-Disposition: inline In-Reply-To: <20140213083316.38D7D822BD@smtp6-g21.free.fr> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org To: Jean-Francois Moine Cc: Dan Carpenter , linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org On Thu, Feb 13, 2014 at 09:13:34AM +0100, Jean-Francois Moine wrote: > When the creation of the second i2c client was failing, the private > buffer was not freed. > > This bug was introduced by the commit 6ae668cc19e8 > 'drm/i2c: tda998x: check the CEC device creation' > > Signed-off-by: Jean-Francois Moine Since David got there first with his patch, which is identical to yours, I'll take his description, and take this as an acked-by for it. -- FTTC broadband for 0.8mile line: 5.8Mbps down 500kbps up. Estimation in database were 13.1 to 19Mbit for a good line, about 7.5+ for a bad. Estimate before purchase was "up to 13.2Mbit".