dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Sylvain BERTRAND <sylware@legeek.net>
To: dri-devel@lists.freedesktop.org
Subject: [radeonsi] si_populate_sq_ramping_values
Date: Mon, 17 Feb 2014 23:08:46 +0100	[thread overview]
Message-ID: <20140217220846.GA285@freedom> (raw)

Hi,

In si_dpm.c, si_populate_sq_ramping_values function,

It should be SISLANDS_DPM2_SQ_RAMP_LTI_RATIO instead of
NISLANDS_DPM2_SQ_RAMP_LTI_RATIO.

----

Moreover should it be:
if (SISLANDS_DPM2_SQ_RAMP_LTI_RATIO > (LTI_RATIO_MASK >>
LTI_RATIO_SHIFT))

instead of:
if (NISLANDS_DPM2_SQ_RAMP_LTI_RATIO <= (LTI_RATIO_MASK >>
LTI_RATIO_SHIFT))

----

The previous does disable "sq ramping" for good on all SI,
expected?

regards,

-- 
Sylvain

             reply	other threads:[~2014-02-17 22:08 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-17 22:08 Sylvain BERTRAND [this message]
2014-02-18 15:17 ` [radeonsi] si_populate_sq_ramping_values Alex Deucher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140217220846.GA285@freedom \
    --to=sylware@legeek.net \
    --cc=dri-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox