From: Lauri Kasanen <cand@gmx.com>
To: "Christian König" <deathsimple@vodafone.de>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/radeon: TTM must be init with cpu-visible VRAM
Date: Fri, 28 Feb 2014 17:30:39 +0200 [thread overview]
Message-ID: <20140228173039.8192741d.cand@gmx.com> (raw)
In-Reply-To: <531058BB.6050100@vodafone.de>
On Fri, 28 Feb 2014 10:36:59 +0100
Christian König <deathsimple@vodafone.de> wrote:
> Am 27.02.2014 22:38, schrieb Lauri Kasanen:
> > Without this, a bo may get created in the cpu-inaccessible vram.
> > Before the CP engines get setup, all copies are done via cpu memcpy.
> >
> > This means that the cpu tries to read from inaccessible memory, fails,
> > and the radeon module proceeds to disable acceleration.
> >
> > Doing this has no downsides, as the real VRAM size gets set as soon as the
> > CP engines get init.
> >
> > This is a candidate for 3.14 fixes.
>
> This should be unnecessary, since TTM gets initialized only seeing the
> visible VRAM and later on radeon_ttm_set_active_vram_size gets called to
> increase the limit.
>
> If this isn't the case any more we should figure out why instead of
> working around it like this.
Negative, TTM gets initialized with real_vram just a few lines above
this patch, not visible_vram.
- Lauri
next prev parent reply other threads:[~2014-02-28 15:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-27 21:38 [PATCH] drm/radeon: TTM must be init with cpu-visible VRAM Lauri Kasanen
2014-02-28 9:36 ` Christian König
2014-02-28 15:30 ` Lauri Kasanen [this message]
2014-02-28 15:36 ` Lauri Kasanen
2014-02-28 15:43 ` Christian König
2014-02-28 16:52 ` Lauri Kasanen
2014-02-28 17:27 ` Christian König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140228173039.8192741d.cand@gmx.com \
--to=cand@gmx.com \
--cc=deathsimple@vodafone.de \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox