From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russell King - ARM Linux Subject: Re: [PATCH] drm/imx: remove drm_mode_connector_detach_encoder harder Date: Sat, 15 Mar 2014 11:23:32 +0000 Message-ID: <20140315112332.GU21483@n2100.arm.linux.org.uk> References: <1394533830-30150-1-git-send-email-daniel.vetter@ffwll.ch> <1394882149-5029-1-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from pandora.arm.linux.org.uk (gw-1.arm.linux.org.uk [78.32.30.217]) by gabe.freedesktop.org (Postfix) with ESMTP id 069C589115 for ; Sat, 15 Mar 2014 04:23:41 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1394882149-5029-1-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter Cc: Greg Kroah-Hartman , DRI Development List-Id: dri-devel@lists.freedesktop.org On Sat, Mar 15, 2014 at 12:15:49PM +0100, Daniel Vetter wrote: > Since the last time I've looked more of this stuff sprouted up. Stomp > it down again. > > Repeating the original justification for ripping this all out: There's > absolutely no need to deteach connectors before cleaning them up at > driver unload time. And since drm doesn't support hotplugging kms > objects at all it's positively dangerous to attempt this at runtime. > Luckily imx only detachs at driver cleanup time and hence we can > savely remove this. Are you looking at what's in linux-next, because if not, you're creating conflicts by making these changes. -- FTTC broadband for 0.8mile line: now at 9.7Mbps down 460kbps up... slowly improving, and getting towards what was expected from it.