From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/imx: remove drm_mode_connector_detach_encoder harder Date: Sat, 15 Mar 2014 12:35:21 +0100 Message-ID: <20140315113521.GH30571@phenom.ffwll.local> References: <1394533830-30150-1-git-send-email-daniel.vetter@ffwll.ch> <1394882149-5029-1-git-send-email-daniel.vetter@ffwll.ch> <20140315112332.GU21483@n2100.arm.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ee0-f51.google.com (mail-ee0-f51.google.com [74.125.83.51]) by gabe.freedesktop.org (Postfix) with ESMTP id 5F16889248 for ; Sat, 15 Mar 2014 04:35:28 -0700 (PDT) Received: by mail-ee0-f51.google.com with SMTP id c13so2317454eek.10 for ; Sat, 15 Mar 2014 04:35:26 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20140315112332.GU21483@n2100.arm.linux.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Russell King - ARM Linux Cc: Daniel Vetter , DRI Development , Greg Kroah-Hartman List-Id: dri-devel@lists.freedesktop.org On Sat, Mar 15, 2014 at 11:23:32AM +0000, Russell King - ARM Linux wrote: > On Sat, Mar 15, 2014 at 12:15:49PM +0100, Daniel Vetter wrote: > > Since the last time I've looked more of this stuff sprouted up. Stomp > > it down again. > > > > Repeating the original justification for ripping this all out: There's > > absolutely no need to deteach connectors before cleaning them up at > > driver unload time. And since drm doesn't support hotplugging kms > > objects at all it's positively dangerous to attempt this at runtime. > > Luckily imx only detachs at driver cleanup time and hence we can > > savely remove this. > > Are you looking at what's in linux-next, because if not, you're creating > conflicts by making these changes. I'm lookint at what's in drm-next, since that's what my pull request is for. Might result in conflicts somewhere else, but they shouldn't be a lot of fuzz to resolve really. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch