From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russell King - ARM Linux Subject: Re: [PATCH 07/12] drm: drm_display_mode: add signal polarity flags Date: Tue, 18 Mar 2014 09:30:35 +0000 Message-ID: <20140318093035.GR21483@n2100.arm.linux.org.uk> References: <1394731053-6118-1-git-send-email-denis@eukrea.com> <2166863.3Fn4k2rvaz@avalon> <20140317161436.06169b33@ipc1.ka-ro> <2777667.XJdaUSpRsD@avalon> <20140318085030.66db84b7@ipc1.ka-ro> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Content-Disposition: inline In-Reply-To: <20140318085030.66db84b7@ipc1.ka-ro> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: driverdev-devel-bounces@linuxdriverproject.org To: Lothar =?iso-8859-1?Q?Wa=DFmann?= Cc: devel@driverdev.osuosl.org, Eric =?iso-8859-1?Q?B=E9nard?= , Denis Carikli , David Airlie , Greg Kroah-Hartman , linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, Andrzej Hajda , Laurent Pinchart , Philipp Zabel , Shawn Guo , Sascha Hauer , linux-arm-kernel@lists.infradead.org, Mauro Carvalho Chehab List-Id: dri-devel@lists.freedesktop.org On Tue, Mar 18, 2014 at 08:50:30AM +0100, Lothar Wa=DFmann wrote: > Hi, > = > Laurent Pinchart wrote: > > Hi Lothar, > > = > > On Monday 17 March 2014 16:14:36 Lothar Wa=DFmann wrote: > > > DE is not a clock signal, but an 'Enable' signal whose value (high or > > > low) defines the window in which the pixel data is valid. > > > The flag defines whether data is valid during the HIGH or LOW period = of > > > DE. > > = > > The DRM_MODE_FLAG_POL_DE_(LOW|HIGH) do, by my impression of the propose= d new = > > DRM_MODE_FLAG_POL_DE_*EDGE flags is that they define sampling clock edg= es, not = > > active levels. > > = > The current naming of the flags gives the impression that they describe > the sampling edges of a clock signal. But the DE signal in fact is not > a clock signal but a level sensitive gating signal. +1 -- = FTTC broadband for 0.8mile line: now at 9.7Mbps down 460kbps up... slowly improving, and getting towards what was expected from it.