From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/mm: Fix search for smallest hole satisfying constraints Date: Wed, 19 Mar 2014 11:38:18 +0100 Message-ID: <20140319103818.GP30571@phenom.ffwll.local> References: <1395104294-28066-1-git-send-email-michel@daenzer.net> <20140318100130.GB30571@phenom.ffwll.local> <1395218547.16819.5.camel@thor.local> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mail-ee0-f44.google.com (mail-ee0-f44.google.com [74.125.83.44]) by gabe.freedesktop.org (Postfix) with ESMTP id 126EA8EC05 for ; Wed, 19 Mar 2014 03:38:22 -0700 (PDT) Received: by mail-ee0-f44.google.com with SMTP id e49so6438764eek.31 for ; Wed, 19 Mar 2014 03:38:22 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1395218547.16819.5.camel@thor.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Michel =?iso-8859-1?Q?D=E4nzer?= Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On Wed, Mar 19, 2014 at 05:42:27PM +0900, Michel D=E4nzer wrote: > On Die, 2014-03-18 at 11:01 +0100, Daniel Vetter wrote: > > On Tue, Mar 18, 2014 at 09:58:14AM +0900, Michel D=E4nzer wrote: > > > From: Michel D=E4nzer > > > = > > > entry->size is the size of the node, not the size of the hole after i= t. > > > So the code would actually find the hole which can satisfy the > > > constraints and which is preceded by the smallest node, not the small= est > > > hole satisfying the constraints. > > > = > > > Reported-by: "Huang, FrankR" > > > Signed-off-by: Michel D=E4nzer > > = > > But drm-next just gained my kerneldoc patch for drm_mm, so can you plea= se > > respin your patch and update the docs too? > = > What kind of update are you thinking of? you've changed the function parameters, which breaks the kerneldoc. v2 is ok in that regard. > > While at it ... could you perhaps smash a bit of kerneldoc on top of > > enum drm_mm_search_flags, I seem to have missed it. With that this is > > = > > Reviewed-by: Daniel Vetter > = > Thanks, but I'm afraid I'll have to pass on that. I'm just submitting a > fix for a problem Frank stumbled upon. I don't have the time right now, > nor the particular inclination to clean up the surrounding code. I've made a note to add the missing kerneldoc, still some patches left over. > Meanwhile, I've submitted a less invasive v2 fix. Reviewed-by: Daniel Vetter on that one. > BTW, do you think the fix would interact properly with coloring? Coloring only adjusts start/end so won't affect the size of the hole. If you really see benefits from best_match then I guess you could look into pessimising holes which need to be split, presuming radeon has a pile of alignment or otherwise constrained buffers. Cheers, Daniel -- = Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch