From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [RFCv3 04/14] drm/exynos: Restrict plane loops to only operate on overlay planes Date: Wed, 19 Mar 2014 12:51:03 +0100 Message-ID: <20140319115102.GV30571@phenom.ffwll.local> References: <1395188579-17191-1-git-send-email-matthew.d.roper@intel.com> <1395188579-17191-5-git-send-email-matthew.d.roper@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ee0-f47.google.com (mail-ee0-f47.google.com [74.125.83.47]) by gabe.freedesktop.org (Postfix) with ESMTP id 8B0F08EC4E for ; Wed, 19 Mar 2014 04:51:07 -0700 (PDT) Received: by mail-ee0-f47.google.com with SMTP id b15so6456880eek.6 for ; Wed, 19 Mar 2014 04:51:06 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1395188579-17191-5-git-send-email-matthew.d.roper@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Matt Roper Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On Tue, Mar 18, 2014 at 05:22:49PM -0700, Matt Roper wrote: > Before we add additional types of planes to the DRM plane list, ensure > that existing loops over all planes continue to operate only on > "overlay" planes and ignore primary & cursor planes. > > Cc: Inki Dae > Signed-off-by: Matt Roper > --- > drivers/gpu/drm/exynos/exynos_drm_encoder.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/gpu/drm/exynos/exynos_drm_encoder.c b/drivers/gpu/drm/exynos/exynos_drm_encoder.c > index 06f1b2a..2fa2685 100644 > --- a/drivers/gpu/drm/exynos/exynos_drm_encoder.c > +++ b/drivers/gpu/drm/exynos/exynos_drm_encoder.c > @@ -127,6 +127,9 @@ static void disable_plane_to_crtc(struct drm_device *dev, > * (encoder->crtc) > */ > list_for_each_entry(plane, &dev->mode_config.plane_list, head) { > + if (plane->type != DRM_PLANE_TYPE_OVERLAY) I think a drm_for_each_legacy_plane iteration helper would be neat for this one and the following i915 patch. -Daniel > + continue; > + > if (plane->crtc == old_crtc) { > /* > * do not change below call order. > @@ -247,6 +250,9 @@ static void exynos_drm_encoder_disable(struct drm_encoder *encoder) > > /* all planes connected to this encoder should be also disabled. */ > list_for_each_entry(plane, &dev->mode_config.plane_list, head) { > + if (plane->type != DRM_PLANE_TYPE_OVERLAY) > + continue; > + > if (plane->crtc == encoder->crtc) > plane->funcs->disable_plane(plane); > } > -- > 1.8.5.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch